arturobernalg commented on PR #765:
URL:
https://github.com/apache/httpcomponents-client/pull/765#issuecomment-3643094319
> > > What "OFFLOCK" mean?
> > > HI @garydgregory. OFFLOCK is selected,
PoolingHttpClientConnectionManager switches to RouteSegmentedConnPool, which
keeps per-route state in independent segments, avoids a single global lock and
offloads slow graceful closes to a bounded executor. The goal is to reduce
contention in highly concurrent workloads while still honouring the same
per-route / total caps as today.
> > > The name was meant as “off-lock / low-lock” policy, but if you prefer
a more explicit name like SEGMENTED (or similar),
>
> Thank you for the explanation @arturobernalg
>
> So the bottom line is that this is not a "lock -free" implementation
("offlock" is very odd phrasing IMO.) This makes me feel that "off" in the name
is inappropriate.
>
> Any other name would be better IMO.
OFFLOCK selects the segmented pool implementation and routes slow graceful
closes off the hot pool locks to reduce lock contention. The name reflects that
intent;
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
