ok2c commented on code in PR #591:
URL:
https://github.com/apache/httpcomponents-core/pull/591#discussion_r2648488966
##########
httpcore5-h2/src/main/java/org/apache/hc/core5/http2/impl/nio/bootstrap/H2ServerBootstrap.java:
##########
@@ -212,7 +213,6 @@ public final H2ServerBootstrap setIOSessionDecorator(final
Decorator<IOSession>
return this;
}
-
Review Comment:
@CoolTomatos do admit the use of line separators is not very consistent
here, but can we avoid formatting changes nevertheless?
##########
httpcore5-h2/src/main/java/org/apache/hc/core5/http2/impl/nio/bootstrap/H2ServerBootstrap.java:
##########
@@ -163,6 +163,7 @@ public final H2ServerBootstrap setVersionPolicy(final
HttpVersionPolicy versionP
* @return this instance.
*/
public final H2ServerBootstrap setH2Config(final H2Config h2Config) {
+ Args.check(!h2Config.isPushEnabled(), "A server MUST NOT set
enable_push according to RFC-9113 6.5.2.");
Review Comment:
@CoolTomatos Can we drop the reference to a specific RFC and a specific
section? RFC do get revised and updated. I do not want to comb for specific RFC
numbers in our code base
##########
httpcore5-h2/src/main/java/org/apache/hc/core5/http2/impl/nio/bootstrap/H2ServerBootstrap.java:
##########
@@ -522,7 +523,7 @@ public HttpAsyncServer create() {
final ServerH2StreamMultiplexerFactory http2StreamHandlerFactory = new
ServerH2StreamMultiplexerFactory(
httpProcessor != null ? httpProcessor : H2Processors.server(),
handlerFactory,
- h2Config != null ? h2Config : H2Config.DEFAULT,
+ h2Config != null ? h2Config :
H2Config.custom().setPushEnabled(false).build(),
Review Comment:
@CoolTomatos This is not necessary, but I leave it up to you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
