ok2c commented on code in PR #785:
URL:
https://github.com/apache/httpcomponents-client/pull/785#discussion_r2695797845
##########
httpclient5/src/main/java/org/apache/hc/client5/http/impl/io/PoolingHttpClientConnectionManager.java:
##########
@@ -444,6 +444,8 @@ public ConnectionEndpoint get(
conn.activate();
if (connectionConfig.getSocketTimeout() != null) {
conn.setSocketTimeout(connectionConfig.getSocketTimeout());
+ } else {
+
conn.setSocketTimeout(resolveSocketConfig(route).getSoTimeout());
Review Comment:
@rschmitt Why is this necessary? `SocketConfig` defines the initial socket
parameters only. It should have no bearing on the persistent connections once
they have been initialized. This change will also likely make behavior of the
classic connection manager inconsistent with that of the async one.
If users want specific socket timeout for their persistent connections they
should be using `ConnectionConfig`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
