arturobernalg commented on PR #613:
URL:
https://github.com/apache/httpcomponents-core/pull/613#issuecomment-3867021765
> @arturobernalg Interesting. How are you going to do integrations tests for
the websocket protocol when it resides in two separate projects? The separation
between core and client for HTTP protocol handlers is reasonably manageable:
the message transport and the core protocol handling reside in core, advanced
client functions reside in client. The core has integration tests that ensure
correctness of the protocol handlers on both ends. in your case, I suspect the
split into the server project and the client project will be hurting you in the
long run. I do not know. This is your decision to make, but you may be better
off having the server side websockets in the client project, at least for a few
minor releases.
@ok2c
moved the server‑side `WebSocket` classes and tests into
`httpclient5‑websocket` as you suggested
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
