arturobernalg commented on code in PR #592:
URL:
https://github.com/apache/httpcomponents-core/pull/592#discussion_r2936685099
##########
httpcore5/src/main/java/org/apache/hc/core5/http/impl/bootstrap/HttpAsyncRequester.java:
##########
@@ -285,6 +289,21 @@ public void execute(
@Override
public void completed(final AsyncClientEndpoint endpoint) {
+ final int max = maxPendingCommandsPerConnection;
+ if (max > 0) {
+ final IOSession ioSession =
((InternalAsyncClientEndpoint) endpoint).getIOSession();
Review Comment:
@ok2c You are right, this was enforced in the wrong layer; I moved the cap
check to InternalAsyncClientEndpoint and kept the original rejection-side reuse
behavior. . This was my solution. I just saw you commit also some changes.
https://github.com/apache/httpcomponents-core/commit/1d40499258e2fdb812b1a3e510e8701320adcfd2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
