ok2c commented on PR #578: URL: https://github.com/apache/httpcomponents-core/pull/578#issuecomment-4090334333
@arturobernalg This is what I think. Micro-benchmarks are nice and they can be useful, but ultimately what matters if a performance optimization feature makes a real and verifiable impact on request execution. This is the benchmark I have been using while working on HttpClient 5.x performance optimization. I can still be useful to collect total execution time / request per seconds metrics of different agents or different message types. It is not very scientific but if it is usually good enough for better / worse performance comparison. If you can find a scenario where pooled ByteBuffer allocator makes a noticeable and verifiable impact, say, of 5% improvement, then it is useful. If not, I am sorry to say I do not think it should be added to the project code. I think there is a chance of making classic over async with very large messages to perform better with this pooled ByteBuffer allocator but I would like to see hard evidence of that. [1] https://github.com/ok2c/httpclient-benchmark -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
