garydgregory commented on code in PR #820:
URL:
https://github.com/apache/httpcomponents-client/pull/820#discussion_r3068484813
##########
httpclient5/src/main/java/org/apache/hc/client5/http/config/ConnectionConfig.java:
##########
@@ -74,34 +84,56 @@ protected ConnectionConfig() {
}
/**
+ * Gets the default socket timeout value for I/O operations on connections
created by this configuration.
+ * A timeout value of zero is interpreted as an infinite timeout.
+ *
+ * @return the default socket timeout value, defaults to null.
* @see Builder#setSocketTimeout(Timeout)
*/
public Timeout getSocketTimeout() {
return socketTimeout;
}
/**
+ * Gets the timeout until a new connection is fully established.
+ * <p>
+ * A timeout value of zero is interpreted as an infinite timeout.
+ * </p>
+ *
+ * @return the timeout until a new connection is fully established,
defaults to 3 minutes.
Review Comment:
TY. Done with
https://github.com/apache/httpcomponents-client/pull/820/changes/dbb960a5565ebb1c0bc4d788ad24f26b7b59fa91
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
