ok2c commented on code in PR #844:
URL:
https://github.com/apache/httpcomponents-client/pull/844#discussion_r3529294289
##########
httpclient5-jakarta-rest-client/src/main/java/org/apache/hc/client5/http/rest/RestInvocationHandler.java:
##########
@@ -162,19 +166,21 @@ private Object executeRequest(final ResourceMethod rm,
for (final Header header : headers) {
request.addHeader(header);
}
- final List<ContentType> consumesContentTypes =
rm.getConsumesContentTypes();
- if (consumesContentTypes != null && !consumesContentTypes.isEmpty()) {
+ // @Produces declares the media type(s) the client accepts back
(Accept header).
Review Comment:
@arturobernalg Indeed. It looks like I made a mistake here. `@Produces`
declares what the endpoint produces and what client can choose to accept. Good
catch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
