arturobernalg commented on code in PR #678:
URL:
https://github.com/apache/httpcomponents-core/pull/678#discussion_r3601308811
##########
.github/workflows/maven.yml:
##########
@@ -57,6 +57,17 @@ jobs:
echo 'HC_BUILD_TOOLCHAIN_VERSION=${{ matrix.java }}' >>
"$GITHUB_ENV"
;;
esac
+ # The httpcore5-jackson3 module is compiled for Java 17 (Jackson 3
Review Comment:
In the client, jakarta-rest-client targets Java 11, so it only breaks on the
Java 8 row — it stays in the reactor and a skip-on-java8 profile no-ops its
build there. jackson3 targets Java 17, so it has to be dropped on both the Java
8 and Java 11 rows, which a single-value skip profile can't express cleanly —
hence the reactor exclusion via the jackson3 profile. Happy to switch core to
the same keep-in-reactor + skip pattern if you'd prefer them consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
