arturobernalg commented on code in PR #869:
URL:
https://github.com/apache/httpcomponents-client/pull/869#discussion_r3815598366
##########
httpclient5/src/main/java/org/apache/hc/client5/http/impl/cookie/RFC6265CookieSpec.java:
##########
@@ -152,22 +159,29 @@ public String toString() {
private RawCookie parseCookie(final CharSequence buffer,
final Tokenizer.Cursor cursor) {
- final String name = tokenParser.parseToken(buffer, cursor,
TOKEN_DELIMS);
- if (name.isEmpty()) {
- return null;
+ final String token = tokenParser.parseToken(buffer, cursor,
TOKEN_DELIMS);
Review Comment:
@ok2c
Yes. The more permissive parsing is required by the 6265bis user-agent
algorithm.
In particular, a Set-Cookie value without = is parsed as a nameless cookie,
and the UA parser is intentionally more permissive than the server grammar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
