prafgup opened a new pull request, #696: URL: https://github.com/apache/httpcomponents-core/pull/696
URIBuilder defaults to ALL_RESERVED, but setEncodingPolicy's Javadoc incorrectly identifies RFC_3986 as the default. Passing null also selects RFC_3986 behavior instead of restoring the documented default. This change corrects the Javadoc and makes null restore ALL_RESERVED. Regression tests cover the default policy, explicit policy selection, and resetting from RFC_3986. Incorrect doc - - https://github.com/apache/httpcomponents-core/blob/4021b98e8e942ccbce8cdf54ec910302821fa740/httpcore5/src/main/java/org/apache/hc/core5/net/URIBuilder.java#L206-L216 Current Default - - https://github.com/apache/httpcomponents-core/blob/4021b98e8e942ccbce8cdf54ec910302821fa740/httpcore5/src/main/java/org/apache/hc/core5/net/URIBuilder.java#L91 Validation: ./mvnw -pl httpcore5 verify passed. All 1,380 tests passed, with no failures, errors, or skips. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
