ok2c commented on code in PR #885: URL: https://github.com/apache/httpcomponents-client/pull/885#discussion_r4052693369
########## httpclient5/src/test/java/org/apache/hc/client5/http/examples/ClientEvictExpiredConnections.java: ########## @@ -31,30 +31,27 @@ import org.apache.hc.client5.http.impl.classic.CloseableHttpClient; import org.apache.hc.client5.http.impl.classic.HttpClients; import org.apache.hc.client5.http.impl.io.PoolingHttpClientConnectionManager; -import org.apache.hc.client5.http.impl.io.PoolingHttpClientConnectionManagerBuilder; import org.apache.hc.core5.http.io.entity.EntityUtils; import org.apache.hc.core5.http.message.StatusLine; -import org.apache.hc.core5.pool.PoolStats; import org.apache.hc.core5.util.TimeValue; /** - * Example demonstrating how to make sure connections connections expire - * after 5 seconds of inactivity and how to proactively evict expired connections - * from the connection pool. + * Example demonstrating how to configure connection keep-alive and Review Comment: @arturobernalg I think we have a conflict here. Could you please pick up my changes? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
