yhzdys commented on PR #700: URL: https://github.com/apache/httpcomponents-core/pull/700#issuecomment-5791077609
> I do not think `BasicAsyncEntityProducer` is the right place to address this problem. Entity producers should not be concerned with JDK socket implementation details or HTTP/2 frame sizes. > > I think should be in `IOSessionImpl.write(ByteBuffer)` or similar. > > Why 16K? Agreed — this belongs in the transport layer (`IOSessionImpl#write(ByteBuffer)` or similar), not in entity producers. I'll rework it there. The 16K choice was not a hard requirement — just a reasonable upper bound: it matches the default HTTP/2 max frame size and the JDK HTTP client's internal buffer size, so it amortizes syscalls while keeping the temporary direct buffer small. At the transport layer it can simply be a constant or a configurable setting; happy to go with whichever you prefer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
