arturobernalg commented on code in PR #706:
URL:
https://github.com/apache/httpcomponents-core/pull/706#discussion_r4123104825
##########
httpcore5-h2/src/main/java/org/apache/hc/core5/http2/hpack/HPackEncoder.java:
##########
@@ -259,8 +259,7 @@ private int findFullMatch(final List<HPackEntry> entries,
final String value) {
if (entries == null || entries.isEmpty()) {
return 0;
}
- for (int i = 0; i < entries.size(); i++) {
- final HPackEntry entry = entries.get(i);
+ for (final HPackEntry entry : entries) {
Review Comment:
> Does this use `Iterator` underneath? Can we make it explicit?
@ok2c Yes, the enhanced for-loop uses an Iterator underneath. changed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
