dxbjavid commented on PR #900: URL: https://github.com/apache/httpcomponents-client/pull/900#issuecomment-6359769132
re-spun as suggested. instead of rewriting the name and value, the spec now rejects a cookie carrying a control character (%x00-1F or %x7F): validate() throws MalformedCookieException, so a Set-Cookie with one is dropped before it reaches the store, and formatCookies() throws IllegalArgumentException per its documented contract rather than writing it into the Cookie header. the sanitising code is gone and the description is updated to match. one thing worth a sanity check: on the write side this fails the request rather than quietly skipping the cookie, which seemed right for something that should never have made it into the store, but i can switch it to skipping with a warning if you'd prefer. 1079 tests and checkstyle pass locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
