parker89 commented on PR #912: URL: https://github.com/apache/httpcomponents-client/pull/912#issuecomment-6611876903
Thanks for picking this up so quickly, closing in favor of #915. Two follow-ups, if useful: - #915 still takes the slow path for any `.` in the path, so dotted segments and file extensions (`/packages/com.example.service/versions/1.2.3`, `/files/report.csv`) only drop from ~2.1 µs / 5 KB to ~1.3-1.6 µs / 3.1-3.4 KB. Only flagging a `.` that starts a segment (`ch == '.' && (previous == '/' || previous == 0)`) keeps those on the fast path, and gives the same results as the merged code for 200k generated paths. Happy to send a small PR with tests. - For 5.6.x, `PathSegmentCodec` isn't in httpcore 5.4.x, so a backport would need the split/decode inlined. I can do that PR too if you'd like it on 5.6.x. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
