arturobernalg commented on PR #923: URL: https://github.com/apache/httpcomponents-client/pull/923#issuecomment-6610652307
> > One more small thing: the new default only kicks in when no IOReactorConfig is passed. IOReactorConfig.custom().setIoThreadCount(4).build() still ends up with soTimeout=0, so tweaking an unrelated setting quietly turns the timeout off again. > > > > @shinseongsu Damn. I completely overlooked that. We will have to change `IOReactorConfig` if we want to do it right. Thank you for pointing it out. > > > > Now, what shall I do about this change-set? Does it still make any sense? Is there any value in having one class with config defaults if all it does is referencing the `#DEFAULT` objects? > > > > @shinseongsu @arturobernalg What do you think? @ok2c I would drop it. If ConfigDefaults only aliases the existing defaults, I don’t think the extra indirection adds much value. The async socket timeout is a separate behavioral change and should be handled independently. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
