PDGGK opened a new pull request, #745:
URL: https://github.com/apache/httpcomponents-core/pull/745
A path that ends with `/` has an empty last segment, and `appendPath` and
`appendPathSegments` add the new segments after it. So a base URI with a
trailing slash, which is how many people write one, picks up a double slash:
```java
new URIBuilder("http://localhost/";).appendPath("api").build(); //
http://localhost//api
new URIBuilder("http://localhost/api/";).appendPath("items/42").build(); //
http://localhost/api//items/42
```
The classic client sends these as `GET //api` and `GET /api//items/42`.
Against an HttpCore classic server with handlers registered for `/api` and
`/api/items/*`, the first request gets `421 Not authoritative` and the second
gets `501`. With this change both get `200`.
The Jakarta REST client in HttpClient runs into the same thing, because
`RestInvocationHandler` adds the resource path to `baseUri` with
`appendPathSegments`. With `baseUri("http://127.0.0.1:<port>/api/")` and a
resource at `items/{id}`, the server receives `GET /api//items/42`, and with
`baseUri("http://127.0.0.1:<port>/")` it receives `GET //items/42`. Against a
core built from this branch it receives `/api/items/42` and `/items/42`.
`ResourceIfaceScanner#join` already drops a trailing empty segment when it
joins the class and method paths, so this change brings `URIBuilder` in line
with it.
`appendPathSegments` now replaces an empty last segment with the appended
segments. A trailing slash on the appended value is kept (`/api/` plus `/v1/`
gives `/api/v1/`, and `/api/` plus `/` stays `/api/`). Appending `null` or an
empty list leaves the path alone, as before.
Tests: `testAppendToPathWithTrailingSlash` and
`testAppendSegmentsToPathWithTrailingSlash` in `TestURIBuilder`. Without the
change they fail with `expected: <https://somehost/api> but was:
<https://somehost//api>` and `expected: <http://myhost/api/v3/products> but
was: <http://myhost//api/v3/products>`. With it, all 82 tests in
`TestURIBuilder` and the 141 tests in `org.apache.hc.core5.net` pass, and
checkstyle passes. I also ran the 84 tests of `httpclient5-jakarta-rest-client`
(HttpClient master) against a core built from this branch, and they pass.
All of this ran on JDK 17 only. I did not run the full HttpCore test suite.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
