Copilot commented on code in PR #937: URL: https://github.com/apache/httpcomponents-client/pull/937#discussion_r4552120386
########## httpclient5-bom/pom.xml: ########## @@ -0,0 +1,86 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + ==================================================================== + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. + ==================================================================== + + This software consists of voluntary contributions made by many + individuals on behalf of the Apache Software Foundation. For more + information on the Apache Software Foundation, please see + <http://www.apache.org />. + --> + <project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> + <parent> + <groupId>org.apache.httpcomponents</groupId> + <artifactId>httpcomponents-parent</artifactId> + <version>15</version> + <relativePath/> + </parent> + <groupId>org.apache.httpcomponents.client5</groupId> + <artifactId>httpclient5-bom</artifactId> + <version>5.7-beta2-SNAPSHOT</version> + <packaging>pom</packaging> + <name>Apache HttpComponents Client BOM</name> + <description>Bill of Materials for Apache HttpComponents Client</description> + <url>https://hc.apache.org/httpcomponents-client-5.7.x/${project.version}/</url> Review Comment: The `url` field in published POM metadata should ideally be stable and resolvable. Using `${project.version}` can produce snapshot/beta URLs that don’t exist (e.g., `*-SNAPSHOT`) and may result in broken links for consumers. Consider pointing to a versionless landing page (e.g., the 5.7.x docs root) or a stable project page instead of interpolating the version. ########## httpclient5-bom/pom.xml: ########## @@ -0,0 +1,86 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + ==================================================================== + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. + ==================================================================== + + This software consists of voluntary contributions made by many + individuals on behalf of the Apache Software Foundation. For more + information on the Apache Software Foundation, please see + <http://www.apache.org />. + --> + <project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> + <parent> + <groupId>org.apache.httpcomponents</groupId> + <artifactId>httpcomponents-parent</artifactId> + <version>15</version> + <relativePath/> + </parent> + <groupId>org.apache.httpcomponents.client5</groupId> + <artifactId>httpclient5-bom</artifactId> + <version>5.7-beta2-SNAPSHOT</version> Review Comment: Because this is added as a reactor module, hardcoding the module version here increases the chance of version drift from the rest of the build (e.g., if the repository version is bumped). A more maintainable approach is to inherit the version from the repository’s root/aggregator parent POM (via a `../pom.xml` relativePath) and omit the explicit `<version>` (and possibly `<groupId>`) so the BOM always stays aligned with the reactor version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
