arturobernalg commented on code in PR #742:
URL:
https://github.com/apache/httpcomponents-core/pull/742#discussion_r4550865446
##########
httpcore5-h2/src/main/java/org/apache/hc/core5/http2/impl/nio/AbstractH2StreamMultiplexer.java:
##########
@@ -970,6 +970,12 @@ private void consumeFrame(final RawFrame frame) throws
HttpException, IOExceptio
final H2Stream stream = streams.lookupSeen(streamId);
if (stream != null) {
final int errorCode = payload.getInt();
+ // Only newly activated peer-initiated streams count.
Valid resets of
+ // long-lived or locally initiated streams remain
unaffected.
+ if (streams.isOtherSide(streamId) && !stream.isReserved()
&& !stream.isClosed()
Review Comment:
@ok2c `isOtherSide()` checks which endpoint initiated the stream, not which
endpoint sent the frame. The peer can also reset locally initiated streams
(e.g. cancelling a server push).
The intention is to limit rapid resets of peer-initiated streams only.
Removing this check would also count resets of locally initiated streams.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
