arturobernalg commented on code in PR #938:
URL:
https://github.com/apache/httpcomponents-client/pull/938#discussion_r4556003145
##########
httpclient5-jakarta-rest-client/src/main/java/org/apache/hc/client5/http/rest/RestInvocationHandler.java:
##########
@@ -157,6 +157,16 @@ private Object executeRequest(final ResourceMethod rm,
pathSegments.add(pathTemplate.getSegment());
}
}
+ if (!pathSegments.isEmpty()) {
Review Comment:
> @arturobernalg Let's make it nicer. Let's not use
`URIBuilder#appendPathSegments` at all. Just join `baseSegments` and
`pathSegments` and set the joined list with `URIBuilder#setPathSegments`
@ok2c Agreed. I’ve updated the PR to join baseSegments and pathSegments
directly and use URIBuilder#setPathSegments, without calling appendPathSegments.
Thanks for the suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
