ok2c commented on PR #943:
URL: 
https://github.com/apache/httpcomponents-client/pull/943#issuecomment-6924339948

   > Is the holder approach OK with you, or would you rather handle this in 
ComplexFuture?
   
   @shinseongsu The approach you have taken looks correct to me. How would 
handle this defect in `ComplexFuture`?
   
   > cancelling during the TLS handshake doesn't close the session in 
DefaultAsyncClientConnectionOperator, and MinimalHttpAsyncClient#leaseEndpoint 
has the same overwrite.
   
   Please do so.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to