shinseongsu commented on PR #945: URL: https://github.com/apache/httpcomponents-client/pull/945#issuecomment-6964288709
Thanks @arturobernalg, @ok2c. I moved the non-repeatable check up so it runs right after `isRedirected()`, before the redirect limit and location checks, same as `RedirectExec`. One behavior change came with it: a POST with a non-repeatable body used to be followed as a GET on 301/302/303, and now it gets the redirect response back, which is what classic does. The test now sends a POST for 301, 302, 303, 307 and 308. It checks that the 3xx response comes back, that the body producer ran once, and that the redirect target never got a request. With the previous commit, the 301/302/303 cases fail on all four transports. Does that match what you had in mind for the method-changing codes? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
