Hsnmohd opened a new pull request, #953: URL: https://github.com/apache/httpcomponents-client/pull/953
an http:// response can plant or replace secure cookies: BasicSecureHandler enforces Secure only in match, never in validate, and ResponseProcessCookies adds the cookie even when it overwrites a Secure one with the same name, domain and path. a network attacker answering one cleartext request to a host the client also uses over https gets session fixation on the secure origin; reproduced with HttpClients against a local http server, after https://localhost set SESSION=victim; Secure, one http response with Set-Cookie: SESSION=attacker made the next https request send Cookie: SESSION=attacker. reject Secure cookies from an insecure origin in BasicSecureHandler.validate and drop an insecure cookie that would overlay a secure one in ResponseProcessCookies, per RFC 6265bis 5.7 (the "leave secure cookies alone" rule browsers enforce). regression tests in TestBasicCookieAttribHandlers and TestResponseProcessCookies. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
