ok2c commented on code in PR #952:
URL:
https://github.com/apache/httpcomponents-client/pull/952#discussion_r4640767036
##########
httpclient5/src/main/java/org/apache/hc/client5/http/utils/DateUtils.java:
##########
@@ -78,13 +79,19 @@ public final class DateUtils {
/**
* Date formatter used to parse HTTP date headers in RFC 1036 format.
+ * <p>
+ * A two-digit year from 70 to 99 is read as 1970 to 1999, and a two-digit
+ * year from 00 to 69 as 2000 to 2069, as RFC 6265 section 5.1.1 requires.
+ * </p>
*
* @since 5.2
*/
public static final DateTimeFormatter FORMATTER_RFC1036 = new
DateTimeFormatterBuilder()
.parseLenient()
.parseCaseInsensitive()
- .appendPattern(PATTERN_RFC1036)
Review Comment:
> japicmp fails on the removed fields, so I added both to the excludes in
the root pom.
@shinseongsu Ah, damn. Those static variables are public. This is my bad.
Please keep them but deprecate instead. Sorry about that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]