Hsnmohd commented on PR #955: URL: https://github.com/apache/httpcomponents-client/pull/955#issuecomment-7046708464
Agreed that RFC 6265 leaves public suffix rejection to user agent configuration (5.3 step 5), so this isn't a spec compliance point. The argument is consistency with what the project already treats as its default: the default cookie policy has validated against the PSL since 4.4, CookieSpecSupport.createDefault() wires PublicSuffixMatcherLoader.getDefault() into the same factory, and #944 just made the no-arg RFC6265LaxSpec and RFC6265StrictSpec constructors do it too. The no-arg factory is the one remaining default-looking entry point that silently produces the unfiltered spec, and it has the same practical consequence #944 fixed: a Domain=com cookie set by foo.com gets sent to bar.com. Anyone who needs the old behavior still has an explicit way to ask for it, new RFC6265CookieSpecFactory(CompatibilityLevel.RELAXED, null), so the change is a default shift rather than a capability loss. I'd keep it for that reason, but if you'd rather preserve the no-arg default as is, I'm fine closing this and we can instead note the opt-out and the asymmetry with #944 in the javadoc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
