Hey Adam,
-----Original Message----- From: Adam Berry <[email protected]> Reply-To: "[email protected]" <[email protected]> Date: Tuesday, April 16, 2013 10:40 AM To: "[email protected]" <[email protected]> Subject: Re: Github pull requests >Hey Chris, > >so the current state is that we do have a pr on an issue, and >https://issues.apache.org/jira/browse/HDT-21?page=com.atlassian.jira.plugi >n.system.issuetabpanels:comment-tabpanel&focusedCommentId=13627796#comment >-13627796is >a link to Mirko stating that we wants to contribute it. OK that should satisfy the intent fine. > I haven't yet >put the patch back up on the issue that represents it, but if I could use >the pull request directly that would obviously easier. Yep I would just attach the patch to the issue, wait like 24-48 hours and then commit it, crediting Mirko. > >How is the license of the patch determined? Just from source headers or >something else? Mirko's comment on JIRA successfully identifies intent; as for the license if it's a larger code base then hopefully it would have a LICENSE.txt file. Since this is just a patch, with intent, I think it's OK to move forward and commit, but this type of diligence should be taken into account each time a contributor contributes something from outside the ASF and JIRA. We used to have a tick mark in JIRA for them to agree to the ALv2 when submitting patches for this very reason. As long as you follow the intent and diligence with these things, [and peer review from your mates are always part of that ;)], then I think we're good. > >Which mailing list would I need to be on to see these and act on them? I would file a https://issues.apache.org/jira/browse/INFRA ticket request for them to set up Github pull request mailing list notifications for HDT [https://github.com/apache/incubator-hdt/] and to have those requests then send to [email protected]. Then when folks at Github make pull requests against https://github.com/apache/incubator-hdt/, we should receive notifications via email here on the ASF lists, which gives us the #1 intent, and #2 wherewithal to incorporate them into the codebase (crediting the upstream contributor). Cheers, Chris ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Chris Mattmann, Ph.D. Senior Computer Scientist NASA Jet Propulsion Laboratory Pasadena, CA 91109 USA Office: 171-266B, Mailstop: 171-246 Email: [email protected] WWW: http://sunset.usc.edu/~mattmann/ ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Adjunct Assistant Professor, Computer Science Department University of Southern California, Los Angeles, CA 90089 USA ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > >On Tue, Apr 16, 2013 at 12:14 PM, Mattmann, Chris A (398J) < >[email protected]> wrote: > >> Hi Adam, >> >> This is totally possible depending on: >> >> * what the user who contributed the patch wanted -- do we have >> some email or some comment that they'd like their code incorporated >> into HDT? >> * the license of that particular patch and its compatibility with >> the ALv2. >> >> Furthermore ASF infra@ has setup (by request of each projects) the >> ability for a project to enable Github pull requests from the >> apache/<project> Github mirror. So when there is a pull request >> there, we will see an email on the ASF mailing list with a link >> to that particular patch and information. >> >> Sorry I'm behind on email -- wondering how this progressed? >> >> Cheers, >> Chris >> >> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ >> Chris Mattmann, Ph.D. >> Senior Computer Scientist >> NASA Jet Propulsion Laboratory Pasadena, CA 91109 USA >> Office: 171-266B, Mailstop: 171-246 >> Email: [email protected] >> WWW: http://sunset.usc.edu/~mattmann/ >> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ >> Adjunct Assistant Professor, Computer Science Department >> University of Southern California, Los Angeles, CA 90089 USA >> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ >> >> >> >> >> >> >> -----Original Message----- >> From: Adam Berry <[email protected]> >> Reply-To: "[email protected]" <[email protected]> >> Date: Tuesday, April 9, 2013 5:59 AM >> To: "[email protected]" <[email protected]> >> Subject: Github pull requests >> >> >Hey guys, >> > >> >So using https://gist.github.com/piscisaureus/3342247 it is possible to >> >work with pull requests outside of github. I'm also all for letting the >> >barrier to entry for newcomers. >> > >> >So i was thinking about making a patch from the request and then adding >> >that to the appropriate jira and then committing from there. Sound >>like a >> >reasonable approach? >> > >> >This came up from Mirko's question on how to contribute a patch. >> > >> >Cheers, >> >Adam >> >>
