Hi Chris, +1 to having both of these in place. For larger patches we can use RB where people think its good to get a look from another set of eyes.
regards, Rahul On Thu, Jun 20, 2013 at 8:42 PM, Mattmann, Chris A (398J) < [email protected]> wrote: > I think Review Board is great! My suggestion though: it's not a > requirement. > > I tend to use Review Board when I want interactive, awesome feedback > from users. But sometimes when it's a new feature, or smaller, or > a bug fix, etc., I just want to CTR it. > > My suggestion is that we do both; and folks use what they get value > of to develop HDT code; to properly review it, and to engage in > the dev process. > > Cheers, > Chris > > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > Chris Mattmann, Ph.D. > Senior Computer Scientist > NASA Jet Propulsion Laboratory Pasadena, CA 91109 USA > Office: 171-266B, Mailstop: 171-246 > Email: [email protected] > WWW: http://sunset.usc.edu/~mattmann/ > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > Adjunct Assistant Professor, Computer Science Department > University of Southern California, Los Angeles, CA 90089 USA > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > > > > > > -----Original Message----- > From: Rahul Sharma <[email protected]> > Reply-To: "[email protected]" <[email protected]> > Date: Wednesday, June 19, 2013 8:54 PM > To: "[email protected]" <[email protected]> > Subject: Code Review : Some ideas > > >Hi, > > > >There has been couple of larger pending patches and new ones will be flow > >in soon. Can we start to have some review/commit process for the same ? I > >do not think our fisheye instance can help us in that. May be we can use > >review board[1] for the purpose. Not sure how much people are comfortable > >with it. I'd suggest that patches should still be attached to a JIRA > >issue (it's > >necessary for legal reasons), but larger ones can additionally be posted > >to > >ReviewBoard. It looks like everybody can create accounts at > >ReviewBoard but INFRA > >needs to set up a group for HDT. > > > >Please let me know your thoughts for the same. > > > >regards, > >Rahul > > > >[1] https://reviews.apache.org > >
