----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16407/ -----------------------------------------------------------
(Updated Jan. 21, 2014, 3:54 p.m.) Review request for helix, Zhen Zhang and Kishore Gopalakrishna. Changes ------- Added a test to make sure that changes in live instances and ideal state are captured in the face of leader elections. Everything else (other than messages) is read every time, so it's not a concern. For messages, we always read the names from ZK, so we don't have to worry about these getting stale (message content never changes in a way that the controller cares). Added the if (trace). Bugs: HELIX-345 Repository: helix-git Description ------- commit 90e995b02a59622a0526897faaee3d6ae057b63e Author: Kanak Biscuitwala <[email protected]> Date: Thu Dec 19 15:44:48 2013 -0800 [HELIX-345] Speed up the controller pipeline for 0.6.x :100644 100644 5c0a94a... 5858958... M helix-core/src/main/java/org/apache/helix/controller/stages/ClusterDataCache.java :100644 100644 df893bb... 9e2452b... M helix-core/src/test/java/org/apache/helix/Mocks.java Diffs (updated) ----- helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java 3b522e6 helix-core/src/main/java/org/apache/helix/controller/stages/ClusterDataCache.java 5c0a94a helix-core/src/main/java/org/apache/helix/controller/stages/ReadClusterDataStage.java f077d29 helix-core/src/main/java/org/apache/helix/controller/stages/TaskAssignmentStage.java 192a645 helix-core/src/test/java/org/apache/helix/Mocks.java df893bb helix-core/src/test/java/org/apache/helix/controller/stages/TestRebalancePipeline.java 1a11be3 helix-core/src/test/java/org/apache/helix/integration/TestReelectedPipelineCorrectness.java PRE-CREATION Diff: https://reviews.apache.org/r/16407/diff/ Testing ------- Tests pass locally, ReadClusterDataStage finishes 10-20% faster in extreme cases. Thanks, Kanak Biscuitwala
