----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17256/#review32770 -----------------------------------------------------------
Ship it! Ship It! - Zhen Zhang On Jan. 23, 2014, 7:38 p.m., Kanak Biscuitwala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17256/ > ----------------------------------------------------------- > > (Updated Jan. 23, 2014, 7:38 p.m.) > > > Review request for helix, Zhen Zhang and Kishore Gopalakrishna. > > > Bugs: HELIX-364 > > > Repository: helix-git > > > Description > ------- > > commit 9a4387927887eb64cb1630dd85eb34d43e3360a7 > Author: Kanak Biscuitwala <[email protected]> > Date: Thu Jan 23 11:33:57 2014 -0800 > > [HELIX-364] Ensure participants and controllers sharing a session id are > treated uniquely > > :100644 100644 28a5b06... e9924a2... M > helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java > :100644 100644 a15e6b3... e8e42bf... M > helix-core/src/main/java/org/apache/helix/controller/stages/ExternalViewComputeStage.java > :100644 100644 9836020... 86b8d41... M > helix-core/src/main/java/org/apache/helix/manager/zk/DistributedLeaderElection.java > :100644 100644 77da158... cc99b8e... M > helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixLeaderElection.java > :100644 100644 45bee64... ee7efcd... M > helix-core/src/main/java/org/apache/helix/participant/DistClusterControllerElection.java > :100644 100644 6066859... d78bd9d... M > helix-core/src/test/java/org/apache/helix/integration/TestSchedulerMessage.java > :000000 100644 0000000... bf89cdb... A > helix-core/src/test/java/org/apache/helix/integration/TestSharedConnection.java > > > Diffs > ----- > > > helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java > 28a5b06 > > helix-core/src/main/java/org/apache/helix/controller/stages/ExternalViewComputeStage.java > a15e6b3 > > helix-core/src/main/java/org/apache/helix/manager/zk/DistributedLeaderElection.java > 9836020 > > helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixLeaderElection.java > 77da158 > > helix-core/src/main/java/org/apache/helix/participant/DistClusterControllerElection.java > 45bee64 > > helix-core/src/test/java/org/apache/helix/integration/TestSchedulerMessage.java > 6066859 > > helix-core/src/test/java/org/apache/helix/integration/TestSharedConnection.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/17256/diff/ > > > Testing > ------- > > Existing tests pass, added two new tests to check for participant and > controller collisions. > > > Thanks, > > Kanak Biscuitwala > >
