So I guess Helix dev start accepting github pull requests from the ASF github mirror? =)
- Henry On Thu, Feb 13, 2014 at 10:51 AM, Kanak Biscuitwala <kana...@hotmail.com> wrote: > Created https://issues.apache.org/jira/browse/INFRA-7318 > > > > ---------------------------------------- >> From: kana...@hotmail.com >> To: dev@helix.apache.org >> Subject: RE: Apache git and github integration >> Date: Wed, 12 Feb 2014 15:32:19 -0800 >> >> Yeah I was referring to the former case. It looks like they took the PR as a >> patch, applied it to the ASF repo, and added "(closes &num)" to the commit >> message. >> >> It definitely makes sense that a PR not accepted and committed requires >> originator action. >> >> ---------------------------------------- >>> Date: Wed, 12 Feb 2014 15:02:01 -0800 >>> Subject: Re: Apache git and github integration >>> From: henry.sapu...@gmail.com >>> To: dev@helix.apache.org >>> >>> Are the PR merged to the repo? If the PR merged to the ASF git repo >>> then once the mirror github is sync it will automatically closed. >>> >>> I was referring to the PRs that are not merged or somehow solved >>> differently. Then the original authors need to close them. >>> >>> - Henry >>> >>> On Wed, Feb 12, 2014 at 2:36 PM, Kanak Biscuitwala <kana...@hotmail.com> >>> wrote: >>>> Henry, >>>> >>>> I've seen other ASF projects be able to use a bot to close the pull >>>> request by putting "closes &PRNUM" in the commit log. Does that still >>>> apply, or is it something else set up by those projects? >>>> >>>> Thanks, >>>> Kanak >>>> >>>>> Date: Wed, 12 Feb 2014 14:10:07 -0800 >>>>> Subject: Re: Apache git and github integration >>>>> From: henry.sapu...@gmail.com >>>>> To: dev@helix.apache.org >>>>> >>>>> The only limitation is that the committers still need to merge >>>>> manually to ASF Git repo instead of the mirror github repo. >>>>> And it needs to maintain the actual comment and author of the commits >>>>> from the original PR for "karma" recording =) >>>>> >>>>> And also if any pull request is not accepted or need update the >>>>> committers cannot close the PRs. Only the original PRs creators can >>>>> close them. >>>>> >>>>> - Henry >>>>> >>>>> On Tue, Feb 11, 2014 at 5:31 PM, kishore g <g.kish...@gmail.com> wrote: >>>>>> Hi Guys, >>>>>> >>>>>> We can have much tighter integration between github and apache git. >>>>>> >>>>>> https://blogs.apache.org/infra/entry/improved_integration_between_apache_and >>>>>> >>>>>> Should we opt in? >>>>>> >>>>>> thanks, >>>>>> Kishore G
