----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17961/#review34890 -----------------------------------------------------------
Ship it! Ship It! - Zhen Zhang On Feb. 11, 2014, 11:18 p.m., Kanak Biscuitwala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17961/ > ----------------------------------------------------------- > > (Updated Feb. 11, 2014, 11:18 p.m.) > > > Review request for helix, Zhen Zhang, Kishore Gopalakrishna, and Shi Lu. > > > Bugs: HELIX-378 > > > Repository: helix-git > > > Description > ------- > > commit 7cb6b86e12c24af7a370c17a8049515337865947 > Author: Kanak Biscuitwala <ka...@apache.org> > Date: Tue Feb 11 14:07:04 2014 -0800 > > [HELIX-378] Add instance gauges to ClusterStatusMonitor > > :100644 100644 2279d76... 85252a0... M > helix-core/src/main/java/org/apache/helix/controller/stages/ReadClusterDataStage.java > :100644 100644 789bb67... b468856... M > helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ClusterStatusMonitor.java > :000000 100644 0000000... 1385568... A > helix-core/src/main/java/org/apache/helix/monitoring/mbeans/InstanceMonitor.java > :000000 100644 0000000... f148700... A > helix-core/src/main/java/org/apache/helix/monitoring/mbeans/InstanceMonitorMBean.java > :100644 100644 f2df162... 6b8b9e3... M > helix-core/src/main/java/org/apache/helix/monitoring/mbeans/MessageQueueMonitor.java > :100644 100644 afd2886... d1ba595... M > helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ResourceMonitor.java > > > Diffs > ----- > > > helix-core/src/main/java/org/apache/helix/controller/stages/ReadClusterDataStage.java > 2279d76 > > helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ClusterStatusMonitor.java > 789bb67 > > helix-core/src/main/java/org/apache/helix/monitoring/mbeans/InstanceMonitor.java > PRE-CREATION > > helix-core/src/main/java/org/apache/helix/monitoring/mbeans/InstanceMonitorMBean.java > PRE-CREATION > > helix-core/src/main/java/org/apache/helix/monitoring/mbeans/MessageQueueMonitor.java > f2df162 > > helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ResourceMonitor.java > afd2886 > > Diff: https://reviews.apache.org/r/17961/diff/ > > > Testing > ------- > > Observed bean server for a controller with these changes and everything was > present > > > Thanks, > > Kanak Biscuitwala > >
