----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18379/#review35216 -----------------------------------------------------------
helix-core/src/main/java/org/apache/helix/messaging/DefaultMessagingService.java <https://reviews.apache.org/r/18379/#comment65670> Why are we giving out the HelixTaskExecutor here? What happens if someone calls shutdown on it? This needs to be deprecated/removed as its a huge risk. - Sandeep Nayak On Feb. 21, 2014, 10:15 p.m., Kanak Biscuitwala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18379/ > ----------------------------------------------------------- > > (Updated Feb. 21, 2014, 10:15 p.m.) > > > Review request for helix, Zhen Zhang and Kishore Gopalakrishna. > > > Bugs: HELIX-390 > > > Repository: helix-git > > > Description > ------- > > commit c48278065c8f119fe92aba1613936c362d470299 > Author: Kanak Biscuitwala <[email protected]> > Date: Fri Feb 21 14:13:21 2014 -0800 > > [HELIX-390] Force message handler registration even when ZK connection > state is flaky > > :100644 100644 da266f9... 42c4f11... M > helix-core/src/main/java/org/apache/helix/manager/zk/ParticipantManagerHelper.java > :100644 100644 56e4be8... 425b2da... M > helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixParticipant.java > :100644 100644 422d35e... b7cb3cb... M > helix-core/src/main/java/org/apache/helix/messaging/DefaultMessagingService.java > > > Diffs > ----- > > > helix-core/src/main/java/org/apache/helix/manager/zk/ParticipantManagerHelper.java > da266f9 > > helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixParticipant.java > 56e4be8 > > helix-core/src/main/java/org/apache/helix/messaging/DefaultMessagingService.java > 422d35e > > Diff: https://reviews.apache.org/r/18379/diff/ > > > Testing > ------- > > > Thanks, > > Kanak Biscuitwala > >
