-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18860/#review36472
-----------------------------------------------------------

Ship it!


Ship It!

- Zhen Zhang


On March 6, 2014, 9:33 p.m., Kanak Biscuitwala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18860/
> -----------------------------------------------------------
> 
> (Updated March 6, 2014, 9:33 p.m.)
> 
> 
> Review request for helix, Zhen Zhang and Kishore Gopalakrishna.
> 
> 
> Bugs: HELIX-398
> 
> 
> Repository: helix-git
> 
> 
> Description
> -------
> 
> commit 4909b44cc43ded4fa0213a73c3c07124a38e53cb
> Author: Kanak Biscuitwala <[email protected]>
> Date:   Thu Mar 6 13:32:22 2014 -0800
> 
>     [HELIX-398] Prevent helix-admin-webapp from running helix-core tests
> 
> :100644 100644 cba086f... 31da4e0... M        
> helix-admin-webapp/src/test/conf/testng.xml
> :100644 000000 c9ebed0... 0000000... D        
> helix-admin-webapp/src/test/java/org/apache/helix/tools/AdminTestBase.java
> :100644 000000 93ff213... 0000000... D        
> helix-admin-webapp/src/test/java/org/apache/helix/tools/AdminTestHelper.java
> :100644 000000 0680764... 0000000... D        
> helix-admin-webapp/src/test/java/org/apache/helix/tools/TestHelixAdminScenariosRest.java
> :100644 000000 fd12080... 0000000... D        
> helix-admin-webapp/src/test/java/org/apache/helix/tools/TestResetInstance.java
> :100644 000000 82a2607... 0000000... D        
> helix-admin-webapp/src/test/java/org/apache/helix/tools/TestResetPartitionState.java
> :100644 000000 db9e9bb... 0000000... D        
> helix-admin-webapp/src/test/java/org/apache/helix/tools/TestResetResource.java
> :000000 100644 0000000... 5b4411b... A        
> helix-admin-webapp/src/test/java/org/apache/helix/webapp/AdminTestBase.java
> :000000 100644 0000000... 9f6946d... A        
> helix-admin-webapp/src/test/java/org/apache/helix/webapp/AdminTestHelper.java
> :100644 100644 1fba6df... b645dfd... M        
> helix-admin-webapp/src/test/java/org/apache/helix/webapp/TestClusterManagementWebapp.java
> :000000 100644 0000000... 7f44174... A        
> helix-admin-webapp/src/test/java/org/apache/helix/webapp/TestHelixAdminScenariosRest.java
> :000000 100644 0000000... fdcb1e5... A        
> helix-admin-webapp/src/test/java/org/apache/helix/webapp/TestResetInstance.java
> :000000 100644 0000000... 3970b7a... A        
> helix-admin-webapp/src/test/java/org/apache/helix/webapp/TestResetPartitionState.java
> :000000 100644 0000000... 64ed249... A        
> helix-admin-webapp/src/test/java/org/apache/helix/webapp/TestResetResource.java
> 
> 
> Diffs
> -----
> 
>   helix-admin-webapp/src/test/conf/testng.xml cba086f 
>   helix-admin-webapp/src/test/java/org/apache/helix/tools/AdminTestBase.java 
> c9ebed0 
>   
> helix-admin-webapp/src/test/java/org/apache/helix/tools/AdminTestHelper.java 
> 93ff213 
>   
> helix-admin-webapp/src/test/java/org/apache/helix/tools/TestHelixAdminScenariosRest.java
>  0680764 
>   
> helix-admin-webapp/src/test/java/org/apache/helix/tools/TestResetInstance.java
>  fd12080 
>   
> helix-admin-webapp/src/test/java/org/apache/helix/tools/TestResetPartitionState.java
>  82a2607 
>   
> helix-admin-webapp/src/test/java/org/apache/helix/tools/TestResetResource.java
>  db9e9bb 
>   helix-admin-webapp/src/test/java/org/apache/helix/webapp/AdminTestBase.java 
> PRE-CREATION 
>   
> helix-admin-webapp/src/test/java/org/apache/helix/webapp/AdminTestHelper.java 
> PRE-CREATION 
>   
> helix-admin-webapp/src/test/java/org/apache/helix/webapp/TestClusterManagementWebapp.java
>  1fba6df 
>   
> helix-admin-webapp/src/test/java/org/apache/helix/webapp/TestHelixAdminScenariosRest.java
>  PRE-CREATION 
>   
> helix-admin-webapp/src/test/java/org/apache/helix/webapp/TestResetInstance.java
>  PRE-CREATION 
>   
> helix-admin-webapp/src/test/java/org/apache/helix/webapp/TestResetPartitionState.java
>  PRE-CREATION 
>   
> helix-admin-webapp/src/test/java/org/apache/helix/webapp/TestResetResource.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/18860/diff/
> 
> 
> Testing
> -------
> 
> All tests pass locally.
> 
> 
> Thanks,
> 
> Kanak Biscuitwala
> 
>

Reply via email to