----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18912/#review36555 -----------------------------------------------------------
Ship it! Might be useful to move the poll method to a test util class. I am sure there are other cases where one needs to wait. - Kishore Gopalakrishna On March 7, 2014, 6:07 p.m., Kanak Biscuitwala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18912/ > ----------------------------------------------------------- > > (Updated March 7, 2014, 6:07 p.m.) > > > Review request for helix, Zhen Zhang and Kishore Gopalakrishna. > > > Bugs: HELIX-399 > > > Repository: helix-git > > > Description > ------- > > commit 50db850b5dceae06163e64b57ed8ed7194e813fb > Author: Kanak Biscuitwala <[email protected]> > Date: Fri Mar 7 10:04:18 2014 -0800 > > [HELIX-399] Make TestConsecutiveZkSessionExpiry less flaky > > :100644 100644 8625c0c... 5985922... M > helix-core/src/test/java/org/apache/helix/integration/manager/TestConsecutiveZkSessionExpiry.java > > > Diffs > ----- > > > helix-core/src/test/java/org/apache/helix/integration/manager/TestConsecutiveZkSessionExpiry.java > 8625c0c > > Diff: https://reviews.apache.org/r/18912/diff/ > > > Testing > ------- > > Test seems to run more reliably locally now. > > > Thanks, > > Kanak Biscuitwala > >
