[
https://issues.apache.org/jira/browse/HELIX-423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13961341#comment-13961341
]
Hudson commented on HELIX-423:
------------------------------
SUCCESS: Integrated in helix #1247 (See
[https://builds.apache.org/job/helix/1247/])
[HELIX-423] Remove election code duplication, fix metrics reset (kanak.b: rev
7937b8a27b8a209d974209f57d5578b3b9e007f2)
*
helix-core/src/main/java/org/apache/helix/manager/zk/DistributedLeaderElection.java
*
helix-core/src/test/java/org/apache/helix/monitoring/mbeans/TestResetClusterMetrics.java
* helix-core/src/test/java/org/apache/helix/participant/MockZKHelixManager.java
*
helix-core/src/test/java/org/apache/helix/participant/TestDistControllerElection.java
*
helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixLeaderElection.java
*
helix-core/src/main/java/org/apache/helix/participant/DistClusterControllerElection.java
> Code duplication in controller leader election
> ----------------------------------------------
>
> Key: HELIX-423
> URL: https://issues.apache.org/jira/browse/HELIX-423
> Project: Apache Helix
> Issue Type: Bug
> Reporter: Kanak Biscuitwala
> Assignee: Kanak Biscuitwala
> Fix For: 0.7.1, 0.6.4
>
>
> There are two (or more) versions of leader election:
> DistributedLeaderElection, DistClusterControllerElection, and possibly others
> that I'm missing. This isn't good because if there's any code change
> required, it's very easy to miss doing it everywhere.
> In particular, this is causing metrics to not be unregistered on leader
> election because this was fixed in one place and not the other.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
