-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19752/#review43512
-----------------------------------------------------------

Ship it!


Ship It!

- Zhen Zhang


On May 20, 2014, 6:12 p.m., Kanak Biscuitwala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19752/
> -----------------------------------------------------------
> 
> (Updated May 20, 2014, 6:12 p.m.)
> 
> 
> Review request for helix, Zhen Zhang and Kishore Gopalakrishna.
> 
> 
> Bugs: HELIX-353
> 
> 
> Repository: helix-git
> 
> 
> Description
> -------
> 
> commit 685d3eb902580bbfdf608eb0804f2682b9d5afab
> Author: Kanak Biscuitwala <[email protected]>
> Date:   Thu Mar 27 13:48:39 2014 -0700
> 
>     [HELIX-353] Write an independent task rebalancer
> 
> :100644 100644 9537272... ac9d748... M        
> helix-core/src/main/java/org/apache/helix/controller/stages/CurrentStateOutput.java
> :000000 100644 0000000... 0ce9eb6... A        
> helix-core/src/main/java/org/apache/helix/task/FixedTargetTaskRebalancer.java
> :000000 100644 0000000... 8e40053... A        
> helix-core/src/main/java/org/apache/helix/task/IndependentTaskRebalancer.java 
> --> GenericTaskRebalancer.java
> :100644 100644 36552fc... 64328d1... M        
> helix-core/src/main/java/org/apache/helix/task/TargetState.java
> :100644 100644 027d7fe... 207fd96... M        
> helix-core/src/main/java/org/apache/helix/task/Task.java
> :100644 100644 4deb588... d03202a... M        
> helix-core/src/main/java/org/apache/helix/task/TaskConfig.java
> :100644 100644 1e822e0... 305323d... M        
> helix-core/src/main/java/org/apache/helix/task/TaskConstants.java
> :100644 100644 6a410e7... e7138a1... M        
> helix-core/src/main/java/org/apache/helix/task/TaskContext.java
> :100644 100644 a237507... f97aef0... M        
> helix-core/src/main/java/org/apache/helix/task/TaskDag.java
> :100644 100644 06e6e4f... 4727728... M        
> helix-core/src/main/java/org/apache/helix/task/TaskDriver.java
> :100644 100644 5133b74... 0cbf24c... M        
> helix-core/src/main/java/org/apache/helix/task/TaskFactory.java
> :100644 100644 f3e182d... d41668d... M        
> helix-core/src/main/java/org/apache/helix/task/TaskPartitionState.java
> :100644 100644 55eca7c... 8214b6a... M        
> helix-core/src/main/java/org/apache/helix/task/TaskRebalancer.java
> :100644 100644 8c6629d... 95b8d72... M        
> helix-core/src/main/java/org/apache/helix/task/TaskResult.java
> :100644 100644 97bf52b... dea383b... M        
> helix-core/src/main/java/org/apache/helix/task/TaskRunner.java
> :100644 100644 5efb01f... 2cc6d6c... M        
> helix-core/src/main/java/org/apache/helix/task/TaskState.java
> :100644 100644 69a3a4e... c5c411c... M        
> helix-core/src/main/java/org/apache/helix/task/TaskStateModel.java
> :100644 100644 4cd85d1... 51e8c95... M        
> helix-core/src/main/java/org/apache/helix/task/TaskStateModelFactory.java
> :100644 100644 741ed4d... f8fcd91... M        
> helix-core/src/main/java/org/apache/helix/task/TaskUtil.java
> :100644 100644 7bc8d73... 3c4bfe7... M        
> helix-core/src/main/java/org/apache/helix/task/Workflow.java
> :100644 100644 322deb7... dbcd55f... M        
> helix-core/src/main/java/org/apache/helix/task/WorkflowConfig.java
> :100644 100644 0c9a9b3... a7e3975... M        
> helix-core/src/main/java/org/apache/helix/task/WorkflowContext.java
> :100644 100644 0efb608... 43ecc46... M        
> helix-core/src/main/java/org/apache/helix/task/beans/TaskBean.java
> :100644 100644 984f0f4... 4e64692... M        
> helix-core/src/main/java/org/apache/helix/task/beans/WorkflowBean.java
> :100644 100644 478e944... e6ec508... M        
> helix-core/src/test/java/org/apache/helix/integration/task/WorkflowGenerator.java
> 
> 
> Diffs
> -----
> 
>   
> helix-core/src/main/java/org/apache/helix/controller/stages/BestPossibleStateCalcStage.java
>  df215c8 
>   
> helix-core/src/main/java/org/apache/helix/controller/stages/CurrentStateOutput.java
>  9537272 
>   
> helix-core/src/main/java/org/apache/helix/task/FixedTargetTaskRebalancer.java 
> PRE-CREATION 
>   helix-core/src/main/java/org/apache/helix/task/GenericTaskRebalancer.java 
> PRE-CREATION 
>   helix-core/src/main/java/org/apache/helix/task/JobConfig.java PRE-CREATION 
>   helix-core/src/main/java/org/apache/helix/task/JobContext.java PRE-CREATION 
>   helix-core/src/main/java/org/apache/helix/task/JobDag.java PRE-CREATION 
>   helix-core/src/main/java/org/apache/helix/task/TargetState.java 36552fc 
>   helix-core/src/main/java/org/apache/helix/task/Task.java 027d7fe 
>   helix-core/src/main/java/org/apache/helix/task/TaskCallbackContext.java 
> PRE-CREATION 
>   helix-core/src/main/java/org/apache/helix/task/TaskConfig.java 4deb588 
>   helix-core/src/main/java/org/apache/helix/task/TaskConstants.java 1e822e0 
>   helix-core/src/main/java/org/apache/helix/task/TaskContext.java 6a410e7 
>   helix-core/src/main/java/org/apache/helix/task/TaskDag.java a237507 
>   helix-core/src/main/java/org/apache/helix/task/TaskDriver.java 06e6e4f 
>   helix-core/src/main/java/org/apache/helix/task/TaskFactory.java 5133b74 
>   helix-core/src/main/java/org/apache/helix/task/TaskPartitionState.java 
> f3e182d 
>   helix-core/src/main/java/org/apache/helix/task/TaskRebalancer.java 55eca7c 
>   helix-core/src/main/java/org/apache/helix/task/TaskResult.java 8c6629d 
>   helix-core/src/main/java/org/apache/helix/task/TaskRunner.java 97bf52b 
>   helix-core/src/main/java/org/apache/helix/task/TaskState.java 5efb01f 
>   helix-core/src/main/java/org/apache/helix/task/TaskStateModel.java 69a3a4e 
>   helix-core/src/main/java/org/apache/helix/task/TaskStateModelFactory.java 
> 4cd85d1 
>   helix-core/src/main/java/org/apache/helix/task/TaskUtil.java 741ed4d 
>   helix-core/src/main/java/org/apache/helix/task/Workflow.java 7bc8d73 
>   helix-core/src/main/java/org/apache/helix/task/WorkflowConfig.java 322deb7 
>   helix-core/src/main/java/org/apache/helix/task/WorkflowContext.java 0c9a9b3 
>   helix-core/src/main/java/org/apache/helix/task/beans/JobBean.java 
> PRE-CREATION 
>   helix-core/src/main/java/org/apache/helix/task/beans/TaskBean.java 0efb608 
>   helix-core/src/main/java/org/apache/helix/task/beans/WorkflowBean.java 
> 984f0f4 
>   
> helix-core/src/test/java/org/apache/helix/integration/TestCustomizedIdealStateRebalancer.java
>  17722f1 
>   
> helix-core/src/test/java/org/apache/helix/integration/task/TestIndependentTaskRebalancer.java
>  PRE-CREATION 
>   
> helix-core/src/test/java/org/apache/helix/integration/task/TestTaskRebalancer.java
>  4839a9a 
>   
> helix-core/src/test/java/org/apache/helix/integration/task/TestTaskRebalancerStopResume.java
>  cd260ee 
>   helix-core/src/test/java/org/apache/helix/integration/task/TestUtil.java 
> 470d59d 
>   
> helix-core/src/test/java/org/apache/helix/integration/task/WorkflowGenerator.java
>  478e944 
> 
> Diff: https://reviews.apache.org/r/19752/diff/
> 
> 
> Testing
> -------
> 
> Existing tests pass.
> 
> 
> Thanks,
> 
> Kanak Biscuitwala
> 
>

Reply via email to