> On May 20, 2014, 8:59 p.m., Kanak Biscuitwala wrote: > > helix-core/src/main/java/org/apache/helix/PropertyPathConfig.java, line 109 > > <https://reviews.apache.org/r/21729/diff/1/?file=585536#file585536line109> > > > > Shouldn't these status updates and persistent stats also be removed?
removed persistent stats, but keep status updates which is not related to stats and alerts - Zhen ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21729/#review43532 ----------------------------------------------------------- On May 20, 2014, 10:40 p.m., Zhen Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21729/ > ----------------------------------------------------------- > > (Updated May 20, 2014, 10:40 p.m.) > > > Review request for helix, Kanak Biscuitwala and Kishore Gopalakrishna. > > > Bugs: HELIX-395 > > > Repository: helix-git > > > Description > ------- > > commit 8525c6a69bbb401dd9785ecb1a5bc2f065701617 > Author: zzhang <[email protected]> > Date: Tue May 20 13:22:02 2014 -0700 > > [HELIX-395] Remove old Helix alert/stat modules > > :100644 000000 9202330... 0000000... D > helix-core/src/main/java/org/apache/helix/HealthStateChangeListener.java > :100644 100644 d5c62fa... 496c73c... M > helix-core/src/main/java/org/apache/helix/HelixAdmin.java > :100644 100644 620db05... 3b40df0... M > helix-core/src/main/java/org/apache/helix/HelixManager.java > :100644 100644 0874958... 1a2f9d2... M > helix-core/src/main/java/org/apache/helix/PropertyKey.java > :100644 100644 96e186d... 963168a... M > helix-core/src/main/java/org/apache/helix/PropertyPathConfig.java > :100644 100644 f6145ed... cbacd35... M > helix-core/src/main/java/org/apache/helix/PropertyType.java > :100644 000000 2967f05... 0000000... D > helix-core/src/main/java/org/apache/helix/alerts/AccumulateAggregator.java > :100644 000000 65a4285... 0000000... D > helix-core/src/main/java/org/apache/helix/alerts/Aggregator.java > :100644 000000 17af060... 0000000... D > helix-core/src/main/java/org/apache/helix/alerts/Alert.java > :100644 000000 c0330c5... 0000000... D > helix-core/src/main/java/org/apache/helix/alerts/AlertComparator.java > :100644 000000 ceb4d2e... 0000000... D > helix-core/src/main/java/org/apache/helix/alerts/AlertParser.java > :100644 000000 2bb1976... 0000000... D > helix-core/src/main/java/org/apache/helix/alerts/AlertProcessor.java > :100644 000000 1582312... 0000000... D > helix-core/src/main/java/org/apache/helix/alerts/AlertValueAndStatus.java > :100644 000000 8bfaae6... 0000000... D > helix-core/src/main/java/org/apache/helix/alerts/AlertsHolder.java > :100644 000000 be17ca9... 0000000... D > helix-core/src/main/java/org/apache/helix/alerts/DecayAggregator.java > :100644 000000 122d4c1... 0000000... D > helix-core/src/main/java/org/apache/helix/alerts/DivideOperator.java > :100644 000000 ecd4791... 0000000... D > helix-core/src/main/java/org/apache/helix/alerts/ExpandOperator.java > :100644 000000 6c4f913... 0000000... D > helix-core/src/main/java/org/apache/helix/alerts/ExpressionOperatorType.java > :100644 000000 ca64be5... 0000000... D > helix-core/src/main/java/org/apache/helix/alerts/ExpressionParser.java > :100644 000000 0e9c8f1... 0000000... D > helix-core/src/main/java/org/apache/helix/alerts/GreaterAlertComparator.java > :100644 000000 74a4688... 0000000... D > helix-core/src/main/java/org/apache/helix/alerts/MultiplyOperator.java > :100644 000000 0612cf3... 0000000... D > helix-core/src/main/java/org/apache/helix/alerts/Operator.java > :100644 000000 6895128... 0000000... D > helix-core/src/main/java/org/apache/helix/alerts/Stat.java > :100644 000000 97ae463... 0000000... D > helix-core/src/main/java/org/apache/helix/alerts/StatsHolder.java > :100644 000000 2cc733f... 0000000... D > helix-core/src/main/java/org/apache/helix/alerts/SumEachOperator.java > :100644 000000 90c9ab0... 0000000... D > helix-core/src/main/java/org/apache/helix/alerts/SumOperator.java > :100644 000000 9a876a4... 0000000... D > helix-core/src/main/java/org/apache/helix/alerts/Tuple.java > :100644 000000 ff4340c... 0000000... D > helix-core/src/main/java/org/apache/helix/alerts/WindowAggregator.java > :100644 000000 bf1d9a6... 0000000... D > helix-core/src/main/java/org/apache/helix/alerts/package-info.java > :100644 100644 33d08f0... b63f314... M > helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java > :100644 000000 3ab8336... 0000000... D > helix-core/src/main/java/org/apache/helix/controller/stages/HealthDataCache.java > :100644 000000 ae873c7... 0000000... D > helix-core/src/main/java/org/apache/helix/controller/stages/ReadHealthDataStage.java > :100644 000000 e531c88... 0000000... D > helix-core/src/main/java/org/apache/helix/controller/stages/StatsAggregationStage.java > :100644 000000 a3c443f... 0000000... D > helix-core/src/main/java/org/apache/helix/healthcheck/AccumulateAggregationType.java > :100644 000000 29f5921... 0000000... D > helix-core/src/main/java/org/apache/helix/healthcheck/AggregationType.java > :100644 000000 d946641... 0000000... D > helix-core/src/main/java/org/apache/helix/healthcheck/AggregationTypeFactory.java > :100644 000000 34e449a... 0000000... D > helix-core/src/main/java/org/apache/helix/healthcheck/DecayAggregationType.java > :100644 000000 b7502f4... 0000000... D > helix-core/src/main/java/org/apache/helix/healthcheck/DefaultHealthReportProvider.java > :100644 000000 e1afd5c... 0000000... D > helix-core/src/main/java/org/apache/helix/healthcheck/DefaultPerfCounters.java > :100644 000000 f7afd04... 0000000... D > helix-core/src/main/java/org/apache/helix/healthcheck/HealthReportProvider.java > :100644 000000 05ffaef... 0000000... D > helix-core/src/main/java/org/apache/helix/healthcheck/HealthStatsAggregationTask.java > :100644 000000 bc95e6d... 0000000... D > helix-core/src/main/java/org/apache/helix/healthcheck/HealthStatsAggregator.java > :100644 000000 266ed8b... 0000000... D > helix-core/src/main/java/org/apache/helix/healthcheck/ParticipantHealthReportCollector.java > :100644 000000 a300a02... 0000000... D > helix-core/src/main/java/org/apache/helix/healthcheck/ParticipantHealthReportCollectorImpl.java > :100644 000000 59d74c7... 0000000... D > helix-core/src/main/java/org/apache/helix/healthcheck/ParticipantHealthReportTask.java > :100644 000000 3a151a7... 0000000... D > helix-core/src/main/java/org/apache/helix/healthcheck/PerformanceHealthReportProvider.java > :100644 000000 d5a31d4... 0000000... D > helix-core/src/main/java/org/apache/helix/healthcheck/Stat.java > :100644 000000 04bb943... 0000000... D > helix-core/src/main/java/org/apache/helix/healthcheck/StatHealthReportProvider.java > :100644 000000 77161af... 0000000... D > helix-core/src/main/java/org/apache/helix/healthcheck/WindowAggregationType.java > :100644 000000 f584b5b... 0000000... D > helix-core/src/main/java/org/apache/helix/healthcheck/package-info.java > :100644 100644 b59976d... bb637c0... M > helix-core/src/main/java/org/apache/helix/manager/zk/CallbackHandler.java > :100644 100644 cfce1da... b80ae55... M > helix-core/src/main/java/org/apache/helix/manager/zk/ParticipantManagerHelper.java > :100644 100644 ff50118... 4fcdae4... M > helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixAdmin.java > :100644 100644 a5ca409... c873e8f... M > helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixManager.java > :100644 000000 b884534... 0000000... D > helix-core/src/main/java/org/apache/helix/model/HealthStat.java > :100644 000000 19634e0... 0000000... D > helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ClusterAlertItem.java > :100644 000000 573391d... 0000000... D > helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ClusterAlertItemMBean.java > :100644 000000 0d06ca3... 0000000... D > helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ClusterAlertMBeanCollection.java > :100644 100644 ada2f99... 1ec6848... M > helix-core/src/main/java/org/apache/helix/task/TaskDriver.java > :100644 100644 2131c3c... 10c8633... M > helix-core/src/main/java/org/apache/helix/tools/ClusterSetup.java > :100644 100644 82d7b6c... 08fc5bc... M > helix-core/src/main/java/org/apache/helix/util/HelixUtil.java > :100644 100644 9e2452b... e36ca54... M > helix-core/src/test/java/org/apache/helix/Mocks.java > :100644 000000 fe4c688... 0000000... D > helix-core/src/test/java/org/apache/helix/TestParticipantHealthReportCollectorImpl.java > :100644 000000 d95bff8... 0000000... D > helix-core/src/test/java/org/apache/helix/TestPerfCounters.java > :100644 000000 60e1bcb... 0000000... D > helix-core/src/test/java/org/apache/helix/TestPerformanceHealthReportProvider.java > :100644 000000 4263ddc... 0000000... D > helix-core/src/test/java/org/apache/helix/alerts/TestAddAlerts.java > :100644 000000 e9e5e32... 0000000... D > helix-core/src/test/java/org/apache/helix/alerts/TestAddPersistentStats.java > :100644 000000 09a9d93... 0000000... D > helix-core/src/test/java/org/apache/helix/alerts/TestAlertValidation.java > :100644 000000 848ef5a... 0000000... D > helix-core/src/test/java/org/apache/helix/alerts/TestArrivingParticipantStats.java > :100644 000000 5183182... 0000000... D > helix-core/src/test/java/org/apache/helix/alerts/TestBaseStatsValidation.java > :100644 000000 403dfdb... 0000000... D > helix-core/src/test/java/org/apache/helix/alerts/TestEvaluateAlerts.java > :100644 000000 2d54a27... 0000000... D > helix-core/src/test/java/org/apache/helix/alerts/TestOperators.java > :100644 000000 094f347... 0000000... D > helix-core/src/test/java/org/apache/helix/alerts/TestStatsMatch.java > :100644 100644 fc9b7d5... 73ba122... M > helix-core/src/test/java/org/apache/helix/controller/stages/DummyClusterManager.java > :100644 000000 eb2f6fe... 0000000... D > helix-core/src/test/java/org/apache/helix/controller/stages/TestParseInfoFromAlert.java > :100644 000000 8e0b04f... 0000000... D > helix-core/src/test/java/org/apache/helix/healthcheck/TestAddDropAlert.java > :100644 000000 b00e26c... 0000000... D > helix-core/src/test/java/org/apache/helix/healthcheck/TestAlertActionTriggering.java > :100644 000000 c18b643... 0000000... D > helix-core/src/test/java/org/apache/helix/healthcheck/TestAlertFireHistory.java > :100644 000000 b8bd634... 0000000... D > helix-core/src/test/java/org/apache/helix/healthcheck/TestDummyAlerts.java > :100644 000000 69b52e7... 0000000... D > helix-core/src/test/java/org/apache/helix/healthcheck/TestExpandAlert.java > :100644 000000 ccc0a79... 0000000... D > helix-core/src/test/java/org/apache/helix/healthcheck/TestSimpleAlert.java > :100644 000000 417a53a... 0000000... D > helix-core/src/test/java/org/apache/helix/healthcheck/TestSimpleWildcardAlert.java > :100644 000000 cdb7d1d... 0000000... D > helix-core/src/test/java/org/apache/helix/healthcheck/TestStalenessAlert.java > :100644 000000 cc819de... 0000000... D > helix-core/src/test/java/org/apache/helix/healthcheck/TestWildcardAlert.java > :100644 100644 9496963... 45a867a... M > helix-core/src/test/java/org/apache/helix/manager/zk/TestZkClusterManager.java > :100644 000000 84ba081... 0000000... D > helix-core/src/test/java/org/apache/helix/mock/participant/MockEspressoHealthReportProvider.java > :100644 000000 31811bb... 0000000... D > helix-core/src/test/java/org/apache/helix/mock/participant/MockHealthReportParticipant.java > :100644 000000 e383291... 0000000... D > helix-core/src/test/java/org/apache/helix/monitoring/mbeans/TestClusterAlertItemMBeanCollection.java > :100644 100644 7d252c5... 11cdd34... M > helix-core/src/test/java/org/apache/helix/participant/MockZKHelixManager.java > > > Diffs > ----- > > helix-core/src/main/java/org/apache/helix/HealthStateChangeListener.java > 9202330 > helix-core/src/main/java/org/apache/helix/HelixAdmin.java d5c62fa > helix-core/src/main/java/org/apache/helix/HelixManager.java 620db05 > helix-core/src/main/java/org/apache/helix/PropertyKey.java 0874958 > helix-core/src/main/java/org/apache/helix/PropertyPathConfig.java 96e186d > helix-core/src/main/java/org/apache/helix/PropertyType.java f6145ed > helix-core/src/main/java/org/apache/helix/alerts/AccumulateAggregator.java > 2967f05 > helix-core/src/main/java/org/apache/helix/alerts/Aggregator.java 65a4285 > helix-core/src/main/java/org/apache/helix/alerts/Alert.java 17af060 > helix-core/src/main/java/org/apache/helix/alerts/AlertComparator.java > c0330c5 > helix-core/src/main/java/org/apache/helix/alerts/AlertParser.java ceb4d2e > helix-core/src/main/java/org/apache/helix/alerts/AlertProcessor.java > 2bb1976 > helix-core/src/main/java/org/apache/helix/alerts/AlertValueAndStatus.java > 1582312 > helix-core/src/main/java/org/apache/helix/alerts/AlertsHolder.java 8bfaae6 > helix-core/src/main/java/org/apache/helix/alerts/DecayAggregator.java > be17ca9 > helix-core/src/main/java/org/apache/helix/alerts/DivideOperator.java > 122d4c1 > helix-core/src/main/java/org/apache/helix/alerts/ExpandOperator.java > ecd4791 > > helix-core/src/main/java/org/apache/helix/alerts/ExpressionOperatorType.java > 6c4f913 > helix-core/src/main/java/org/apache/helix/alerts/ExpressionParser.java > ca64be5 > > helix-core/src/main/java/org/apache/helix/alerts/GreaterAlertComparator.java > 0e9c8f1 > helix-core/src/main/java/org/apache/helix/alerts/MultiplyOperator.java > 74a4688 > helix-core/src/main/java/org/apache/helix/alerts/Operator.java 0612cf3 > helix-core/src/main/java/org/apache/helix/alerts/Stat.java 6895128 > helix-core/src/main/java/org/apache/helix/alerts/StatsHolder.java 97ae463 > helix-core/src/main/java/org/apache/helix/alerts/SumEachOperator.java > 2cc733f > helix-core/src/main/java/org/apache/helix/alerts/SumOperator.java 90c9ab0 > helix-core/src/main/java/org/apache/helix/alerts/Tuple.java 9a876a4 > helix-core/src/main/java/org/apache/helix/alerts/WindowAggregator.java > ff4340c > helix-core/src/main/java/org/apache/helix/alerts/package-info.java bf1d9a6 > > helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java > 33d08f0 > > helix-core/src/main/java/org/apache/helix/controller/stages/HealthDataCache.java > 3ab8336 > > helix-core/src/main/java/org/apache/helix/controller/stages/ReadHealthDataStage.java > ae873c7 > > helix-core/src/main/java/org/apache/helix/controller/stages/StatsAggregationStage.java > e531c88 > > helix-core/src/main/java/org/apache/helix/healthcheck/AccumulateAggregationType.java > a3c443f > helix-core/src/main/java/org/apache/helix/healthcheck/AggregationType.java > 29f5921 > > helix-core/src/main/java/org/apache/helix/healthcheck/AggregationTypeFactory.java > d946641 > > helix-core/src/main/java/org/apache/helix/healthcheck/DecayAggregationType.java > 34e449a > > helix-core/src/main/java/org/apache/helix/healthcheck/DefaultHealthReportProvider.java > b7502f4 > > helix-core/src/main/java/org/apache/helix/healthcheck/DefaultPerfCounters.java > e1afd5c > > helix-core/src/main/java/org/apache/helix/healthcheck/HealthReportProvider.java > f7afd04 > > helix-core/src/main/java/org/apache/helix/healthcheck/HealthStatsAggregationTask.java > 05ffaef > > helix-core/src/main/java/org/apache/helix/healthcheck/HealthStatsAggregator.java > bc95e6d > > helix-core/src/main/java/org/apache/helix/healthcheck/ParticipantHealthReportCollector.java > 266ed8b > > helix-core/src/main/java/org/apache/helix/healthcheck/ParticipantHealthReportCollectorImpl.java > a300a02 > > helix-core/src/main/java/org/apache/helix/healthcheck/ParticipantHealthReportTask.java > 59d74c7 > > helix-core/src/main/java/org/apache/helix/healthcheck/PerformanceHealthReportProvider.java > 3a151a7 > helix-core/src/main/java/org/apache/helix/healthcheck/Stat.java d5a31d4 > > helix-core/src/main/java/org/apache/helix/healthcheck/StatHealthReportProvider.java > 04bb943 > > helix-core/src/main/java/org/apache/helix/healthcheck/WindowAggregationType.java > 77161af > helix-core/src/main/java/org/apache/helix/healthcheck/package-info.java > f584b5b > helix-core/src/main/java/org/apache/helix/manager/zk/CallbackHandler.java > b59976d > > helix-core/src/main/java/org/apache/helix/manager/zk/ParticipantManagerHelper.java > cfce1da > helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixAdmin.java > ff50118 > helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixManager.java > a5ca409 > helix-core/src/main/java/org/apache/helix/model/HealthStat.java b884534 > > helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ClusterAlertItem.java > 19634e0 > > helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ClusterAlertItemMBean.java > 573391d > > helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ClusterAlertMBeanCollection.java > 0d06ca3 > helix-core/src/main/java/org/apache/helix/task/TaskDriver.java ada2f99 > helix-core/src/main/java/org/apache/helix/tools/ClusterSetup.java 2131c3c > helix-core/src/main/java/org/apache/helix/util/HelixUtil.java 82d7b6c > helix-core/src/test/java/org/apache/helix/Mocks.java 9e2452b > > helix-core/src/test/java/org/apache/helix/TestParticipantHealthReportCollectorImpl.java > fe4c688 > helix-core/src/test/java/org/apache/helix/TestPerfCounters.java d95bff8 > > helix-core/src/test/java/org/apache/helix/TestPerformanceHealthReportProvider.java > 60e1bcb > helix-core/src/test/java/org/apache/helix/alerts/TestAddAlerts.java 4263ddc > > helix-core/src/test/java/org/apache/helix/alerts/TestAddPersistentStats.java > e9e5e32 > helix-core/src/test/java/org/apache/helix/alerts/TestAlertValidation.java > 09a9d93 > > helix-core/src/test/java/org/apache/helix/alerts/TestArrivingParticipantStats.java > 848ef5a > > helix-core/src/test/java/org/apache/helix/alerts/TestBaseStatsValidation.java > 5183182 > helix-core/src/test/java/org/apache/helix/alerts/TestEvaluateAlerts.java > 403dfdb > helix-core/src/test/java/org/apache/helix/alerts/TestOperators.java 2d54a27 > helix-core/src/test/java/org/apache/helix/alerts/TestStatsMatch.java > 094f347 > > helix-core/src/test/java/org/apache/helix/controller/stages/DummyClusterManager.java > fc9b7d5 > > helix-core/src/test/java/org/apache/helix/controller/stages/TestParseInfoFromAlert.java > eb2f6fe > helix-core/src/test/java/org/apache/helix/healthcheck/TestAddDropAlert.java > 8e0b04f > > helix-core/src/test/java/org/apache/helix/healthcheck/TestAlertActionTriggering.java > b00e26c > > helix-core/src/test/java/org/apache/helix/healthcheck/TestAlertFireHistory.java > c18b643 > helix-core/src/test/java/org/apache/helix/healthcheck/TestDummyAlerts.java > b8bd634 > helix-core/src/test/java/org/apache/helix/healthcheck/TestExpandAlert.java > 69b52e7 > helix-core/src/test/java/org/apache/helix/healthcheck/TestSimpleAlert.java > ccc0a79 > > helix-core/src/test/java/org/apache/helix/healthcheck/TestSimpleWildcardAlert.java > 417a53a > > helix-core/src/test/java/org/apache/helix/healthcheck/TestStalenessAlert.java > cdb7d1d > > helix-core/src/test/java/org/apache/helix/healthcheck/TestWildcardAlert.java > cc819de > > helix-core/src/test/java/org/apache/helix/manager/zk/TestZkClusterManager.java > 9496963 > > helix-core/src/test/java/org/apache/helix/mock/participant/MockEspressoHealthReportProvider.java > 84ba081 > > helix-core/src/test/java/org/apache/helix/mock/participant/MockHealthReportParticipant.java > 31811bb > > helix-core/src/test/java/org/apache/helix/monitoring/mbeans/TestClusterAlertItemMBeanCollection.java > e383291 > > helix-core/src/test/java/org/apache/helix/participant/MockZKHelixManager.java > 7d252c5 > > Diff: https://reviews.apache.org/r/21729/diff/ > > > Testing > ------- > > > Thanks, > > Zhen Zhang > >
