----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21745/#review43563 -----------------------------------------------------------
Ship it! Ship It! - Kanak Biscuitwala On May 20, 2014, 5:59 p.m., Zhen Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21745/ > ----------------------------------------------------------- > > (Updated May 20, 2014, 5:59 p.m.) > > > Review request for helix, Kanak Biscuitwala and Kishore Gopalakrishna. > > > Bugs: HELIX-446 > > > Repository: helix-git > > > Description > ------- > > commit 3146762b2e3c171ed70d1cf5587c2c85992bbfa8 > Author: zzhang <zzh...@apache.org> > Date: Tue May 20 17:56:01 2014 -0700 > > [HELIX-446] Remove ZkPropertyTransfer and restlet dependency from > helix-core > > :100644 100644 c70e8fc... 09e5a22... M helix-core/pom.xml > :100644 100644 a391f85... 32c9fd3... M > helix-core/src/main/java/org/apache/helix/PropertyType.java > :100644 100644 62f3b23... b6c16b5... M > helix-core/src/main/java/org/apache/helix/controller/HelixControllerMain.java > :100644 000000 e415da9... 0000000... D > helix-core/src/main/java/org/apache/helix/controller/restlet/ZKPropertyTransferServer.java > :100644 000000 deef748... 0000000... D > helix-core/src/main/java/org/apache/helix/controller/restlet/ZNRecordUpdate.java > :100644 000000 33593ae... 0000000... D > helix-core/src/main/java/org/apache/helix/controller/restlet/ZNRecordUpdateResource.java > :100644 000000 68d35cb... 0000000... D > helix-core/src/main/java/org/apache/helix/controller/restlet/ZkPropertyTransferApplication.java > :100644 000000 092d845... 0000000... D > helix-core/src/main/java/org/apache/helix/controller/restlet/ZkPropertyTransferClient.java > :100644 000000 0ef7a79... 0000000... D > helix-core/src/main/java/org/apache/helix/controller/restlet/package-info.java > :100644 100644 3175e8d... d281ae4... M > helix-core/src/main/java/org/apache/helix/manager/zk/DistributedLeaderElection.java > :100644 100644 b80ae55... 1bee2fe... M > helix-core/src/main/java/org/apache/helix/manager/zk/ParticipantManagerHelper.java > :100644 100644 94e8feb... cacc20d... M > helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixDataAccessor.java > :100644 100644 ed6c8a8... a24ec32... M > helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixManager.java > :100644 100644 bd37d42... 2d7cb3c... M > helix-core/src/main/java/org/apache/helix/manager/zk/ZNRecordStreamingSerializer.java > :100644 100644 cdf11fe... 3a321cc... M > helix-core/src/test/java/org/apache/helix/controller/stages/TestMessageThrottleStage.java > :100644 100644 746b463... 4f6f306... M > helix-core/src/test/java/org/apache/helix/integration/TestAutoRebalance.java > :100644 100644 74a5699... f7eaf00... M > helix-core/src/test/java/org/apache/helix/integration/TestAutoRebalancePartitionLimit.java > :100644 100644 38903c7... 26b9cb0... M > helix-core/src/test/java/org/apache/helix/integration/TestCustomizedIdealStateRebalancer.java > :100644 100644 be523d0... ca54fb3... M > helix-core/src/test/java/org/apache/helix/integration/TestDisableNode.java > :100644 100644 fcfc744... 83d7b14... M > helix-core/src/test/java/org/apache/helix/integration/TestDisablePartition.java > :100644 100644 0d02d12... 047ea75... M > helix-core/src/test/java/org/apache/helix/integration/TestDropResource.java > :100644 100644 457b5fb... 704d4d3... M > helix-core/src/test/java/org/apache/helix/integration/TestMessagingService.java > :100644 100644 49fd98c... 7cd64d7... M > helix-core/src/test/java/org/apache/helix/integration/TestSchedulerMessage.java > :100644 100644 7759761... d874fcf... M > helix-core/src/test/java/org/apache/helix/integration/TestZkCallbackHandlerLeak.java > :100644 000000 c6fbea6... 0000000... D > helix-core/src/test/java/org/apache/helix/integration/ZkStandAloneCMTestBaseWithPropertyServerCheck.java > :100644 100644 8bff2fb... 69448dc... M > helix-core/src/test/java/org/apache/helix/integration/manager/TestConsecutiveZkSessionExpiry.java > :100644 100644 aa00a8d... f797d1b... M > helix-core/src/test/java/org/apache/helix/integration/manager/TestDistributedControllerManager.java > :100644 100644 59a3fd9... 9b3c32f... M > helix-core/src/test/java/org/apache/helix/integration/manager/TestZkCallbackHandlerLeak.java > :100644 100644 547e863... c2982b2... M > helix-core/src/test/java/org/apache/helix/manager/zk/TestLiveInstanceBounce.java > :100644 000000 50a9a78... 0000000... D > helix-core/src/test/java/org/apache/helix/manager/zk/TestZKPropertyTransferServer.java > :100644 100644 98ce3a4... b016ce8... M > helix-core/src/test/java/org/apache/helix/manager/zk/TestZkStateChangeListener.java > > > Diffs > ----- > > helix-core/pom.xml c70e8fc > helix-core/src/main/java/org/apache/helix/PropertyType.java a391f85 > > helix-core/src/main/java/org/apache/helix/controller/HelixControllerMain.java > 62f3b23 > > helix-core/src/main/java/org/apache/helix/controller/restlet/ZKPropertyTransferServer.java > e415da9 > > helix-core/src/main/java/org/apache/helix/controller/restlet/ZNRecordUpdate.java > deef748 > > helix-core/src/main/java/org/apache/helix/controller/restlet/ZNRecordUpdateResource.java > 33593ae > > helix-core/src/main/java/org/apache/helix/controller/restlet/ZkPropertyTransferApplication.java > 68d35cb > > helix-core/src/main/java/org/apache/helix/controller/restlet/ZkPropertyTransferClient.java > 092d845 > > helix-core/src/main/java/org/apache/helix/controller/restlet/package-info.java > 0ef7a79 > > helix-core/src/main/java/org/apache/helix/manager/zk/DistributedLeaderElection.java > 3175e8d > > helix-core/src/main/java/org/apache/helix/manager/zk/ParticipantManagerHelper.java > b80ae55 > > helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixDataAccessor.java > 94e8feb > helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixManager.java > ed6c8a8 > > helix-core/src/main/java/org/apache/helix/manager/zk/ZNRecordStreamingSerializer.java > bd37d42 > > helix-core/src/test/java/org/apache/helix/controller/stages/TestMessageThrottleStage.java > cdf11fe > > helix-core/src/test/java/org/apache/helix/integration/TestAutoRebalance.java > 746b463 > > helix-core/src/test/java/org/apache/helix/integration/TestAutoRebalancePartitionLimit.java > 74a5699 > > helix-core/src/test/java/org/apache/helix/integration/TestCustomizedIdealStateRebalancer.java > 38903c7 > helix-core/src/test/java/org/apache/helix/integration/TestDisableNode.java > be523d0 > > helix-core/src/test/java/org/apache/helix/integration/TestDisablePartition.java > fcfc744 > helix-core/src/test/java/org/apache/helix/integration/TestDropResource.java > 0d02d12 > > helix-core/src/test/java/org/apache/helix/integration/TestMessagingService.java > 457b5fb > > helix-core/src/test/java/org/apache/helix/integration/TestSchedulerMessage.java > 49fd98c > > helix-core/src/test/java/org/apache/helix/integration/TestZkCallbackHandlerLeak.java > 7759761 > > helix-core/src/test/java/org/apache/helix/integration/ZkStandAloneCMTestBaseWithPropertyServerCheck.java > c6fbea6 > > helix-core/src/test/java/org/apache/helix/integration/manager/TestConsecutiveZkSessionExpiry.java > 8bff2fb > > helix-core/src/test/java/org/apache/helix/integration/manager/TestDistributedControllerManager.java > aa00a8d > > helix-core/src/test/java/org/apache/helix/integration/manager/TestZkCallbackHandlerLeak.java > 59a3fd9 > > helix-core/src/test/java/org/apache/helix/manager/zk/TestLiveInstanceBounce.java > 547e863 > > helix-core/src/test/java/org/apache/helix/manager/zk/TestZKPropertyTransferServer.java > 50a9a78 > > helix-core/src/test/java/org/apache/helix/manager/zk/TestZkStateChangeListener.java > 98ce3a4 > > Diff: https://reviews.apache.org/r/21745/diff/ > > > Testing > ------- > > > Thanks, > > Zhen Zhang > >
