> On May 27, 2014, 1:44 p.m., Kishore Gopalakrishna wrote: > > helix-core/src/main/java/org/apache/helix/task/JobConfig.java, line 95 > > <https://reviews.apache.org/r/21879/diff/1/?file=591145#file591145line95> > > > > too big, can we have a builder ?
The builder already exists, and it is the only thing that ever invokes this private constructor directly. > On May 27, 2014, 1:44 p.m., Kishore Gopalakrishna wrote: > > helix-core/src/main/java/org/apache/helix/task/GenericTaskRebalancer.java, > > line 201 > > <https://reviews.apache.org/r/21879/diff/1/?file=591144#file591144line201> > > > > should we extract this into retrypolicy interface ? Sure, I'll move this out so that we can support pluggable policies later. - Kanak ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21879/#review44035 ----------------------------------------------------------- On May 23, 2014, 2:24 p.m., Kanak Biscuitwala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21879/ > ----------------------------------------------------------- > > (Updated May 23, 2014, 2:24 p.m.) > > > Review request for helix, Zhen Zhang and Kishore Gopalakrishna. > > > Bugs: HELIX-438 > > > Repository: helix-git > > > Description > ------- > > commit f67147eec6fefda61310df8b8a5fc7eae3594431 > Author: Kanak Biscuitwala <[email protected]> > Date: Fri May 23 14:22:48 2014 -0700 > > [HELIX-438] Improve task framework retry logic > > :100644 100644 dc6fbaa... 4c4fee1... M > helix-core/src/main/java/org/apache/helix/task/FixedTargetTaskRebalancer.java > :100644 100644 9174eb1... 8a54eed... M > helix-core/src/main/java/org/apache/helix/task/GenericTaskRebalancer.java > :100644 100644 b166da1... 3f9ab41... M > helix-core/src/main/java/org/apache/helix/task/JobConfig.java > :100644 100644 849f339... a6244c8... M > helix-core/src/main/java/org/apache/helix/task/TaskRebalancer.java > :100644 100644 dea383b... a0d74c8... M > helix-core/src/main/java/org/apache/helix/task/TaskRunner.java > :100644 100644 537f287... 57404d8... M > helix-core/src/main/java/org/apache/helix/task/Workflow.java > :100644 100644 af5882c... bc5350a... M > helix-core/src/main/java/org/apache/helix/task/beans/JobBean.java > :100644 100644 7041db8... 10f0ac7... M > helix-core/src/test/java/org/apache/helix/integration/task/TestIndependentTaskRebalancer.java > > > Diffs > ----- > > > helix-core/src/main/java/org/apache/helix/task/FixedTargetTaskRebalancer.java > dc6fbaa > helix-core/src/main/java/org/apache/helix/task/GenericTaskRebalancer.java > 9174eb1 > helix-core/src/main/java/org/apache/helix/task/JobConfig.java b166da1 > helix-core/src/main/java/org/apache/helix/task/TaskRebalancer.java 849f339 > helix-core/src/main/java/org/apache/helix/task/TaskRunner.java dea383b > helix-core/src/main/java/org/apache/helix/task/Workflow.java 537f287 > helix-core/src/main/java/org/apache/helix/task/beans/JobBean.java af5882c > > helix-core/src/test/java/org/apache/helix/integration/task/TestIndependentTaskRebalancer.java > 7041db8 > > Diff: https://reviews.apache.org/r/21879/diff/ > > > Testing > ------- > > Added a new test to ensure that the rebalancer can choose new participants. > > > Thanks, > > Kanak Biscuitwala > >
