[ 
https://issues.apache.org/jira/browse/HELIX-448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14062478#comment-14062478
 ] 

Hudson commented on HELIX-448:
------------------------------

UNSTABLE: Integrated in helix #1261 (See 
[https://builds.apache.org/job/helix/1261/])
[HELIX-448] Call onCallback for CustomCodeCallbackHandler for FINALIZE (kanak: 
rev 67be36e02cf8197c9fa19986040636b960463a3f)
* 
helix-core/src/test/java/org/apache/helix/integration/TestDisableCustomCodeRunner.java
* helix-core/src/main/java/org/apache/helix/participant/CustomCodeInvoker.java


> Call onCallback for CustomCodeCallbackHandler for FINALIZE type
> ---------------------------------------------------------------
>
>                 Key: HELIX-448
>                 URL: https://issues.apache.org/jira/browse/HELIX-448
>             Project: Apache Helix
>          Issue Type: Bug
>            Reporter: Kanak Biscuitwala
>            Assignee: Kanak Biscuitwala
>
> Many use cases assume that onCallback will be invoked with type FINALIZE when 
> leadership is lost so that there is an opportunity to clean up. However, this 
> is not the case, and the previous leader has no idea that it's not leader 
> anymore.
> Long term the right thing to do is to split onCallback into 3 different 
> methods, but for now, we should also invoke onCallback with the appropriate 
> type, since this seems to be the expected behavior.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to