----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23956/ -----------------------------------------------------------
Review request for helix, Zhen Zhang and Kishore Gopalakrishna. Bugs: HELIX-483 Repository: helix-git Description ------- This change is all about removing code duplication and keeping the config classes simple and small high-level groupings on the physical model. Methods were removed when there's multiple ways to do the same thing, but the overall goal of the logical config classes is maintained. commit ff958b19f0911ad337439616ada746eee7c95e23 Author: Kanak Biscuitwala <[email protected]> Date: Fri Jul 25 16:33:35 2014 -0700 [HELIX-483] Simplify logical config classes :100644 100644 adaf200... 421ff60... M helix-core/src/main/java/org/apache/helix/api/Cluster.java :100644 100644 c94a6e1... d4cfaf3... M helix-core/src/main/java/org/apache/helix/api/Controller.java :100644 100644 3ed395b... ad6811b... M helix-core/src/main/java/org/apache/helix/api/Participant.java :100644 100644 239748c... 3a7a9f2... M helix-core/src/main/java/org/apache/helix/api/Resource.java :100644 000000 4e5aedb... 0000000... D helix-core/src/main/java/org/apache/helix/api/RunningInstance.java :100644 100644 21d40b1... 70e600b... M helix-core/src/main/java/org/apache/helix/api/accessor/ClusterAccessor.java :100644 100644 d5dd337... f39482c... M helix-core/src/main/java/org/apache/helix/api/config/ClusterConfig.java :100644 100644 119ff52... 4fd42b9... M helix-core/src/main/java/org/apache/helix/api/config/ParticipantConfig.java :100644 100644 26df5d7... fd9f20f... M helix-core/src/main/java/org/apache/helix/api/config/ResourceConfig.java :100644 100644 addd652... d51d546... M helix-core/src/main/java/org/apache/helix/controller/rebalancer/util/ConstraintBasedAssignment.java :100644 100644 15264ca... a498773... M helix-core/src/main/java/org/apache/helix/controller/stages/CompatibilityCheckStage.java :100644 100644 25645d3... f062766... M helix-core/src/main/java/org/apache/helix/controller/stages/ContainerProvisioningStage.java :100644 100644 4cc1b9f... e554324... M helix-core/src/main/java/org/apache/helix/controller/stages/CurrentStateComputationStage.java :100644 100644 9f2721f... deabb56... M helix-core/src/main/java/org/apache/helix/controller/stages/ExternalViewComputeStage.java :100644 100644 893e116... 61da673... M helix-core/src/main/java/org/apache/helix/controller/stages/MessageGenerationStage.java :100644 100644 b5ed39e... 2408e29... M helix-core/src/main/java/org/apache/helix/controller/stages/MessageSelectionStage.java :100644 100644 1fc7142... 1036b35... M helix-core/src/main/java/org/apache/helix/controller/stages/ResourceComputationStage.java :100644 100644 aa47b4b... 9d6228e... M helix-core/src/main/java/org/apache/helix/controller/stages/TaskAssignmentStage.java :100644 100644 2dde23e... c386035... M helix-core/src/main/java/org/apache/helix/model/InstanceConfig.java :100644 100644 452ca65... 001b792... M helix-core/src/main/java/org/apache/helix/model/ResourceConfiguration.java :100644 100644 29990ed... 7fdf734... M helix-core/src/main/java/org/apache/helix/task/TaskRebalancer.java :100644 100644 761ffe2... 0e1402d... M helix-core/src/test/java/org/apache/helix/api/TestNamespacedConfig.java :100644 100644 a8d1589... feed534... M helix-core/src/test/java/org/apache/helix/api/TestUpdateConfig.java :100644 100644 9122e62... fd5bc76... M helix-core/src/test/java/org/apache/helix/api/accessor/TestAtomicAccessors.java :100644 100644 8b26d86... 5456884... M helix-core/src/test/java/org/apache/helix/controller/stages/BaseStageTest.java :100644 100644 46c0fd9... c09e937... M helix-core/src/test/java/org/apache/helix/controller/stages/TestMsgSelectionStage.java :100644 100644 c8ec90a... 4535df5... M helix-core/src/test/java/org/apache/helix/controller/strategy/TestNewAutoRebalanceStrategy.java :100644 100644 911832a... e39615d... M helix-core/src/test/java/org/apache/helix/integration/task/TestTaskRebalancer.java :100644 100644 163ac5e... 9e897a0... M helix-examples/src/main/java/org/apache/helix/examples/LogicalModelExample.java :100644 100644 fcc137b... b84fae6... M helix-provisioning/src/main/java/org/apache/helix/provisioning/tools/ContainerAdmin.java :100644 100644 7d7883e... 558d033... M helix-provisioning/src/main/java/org/apache/helix/provisioning/yarn/NMCallbackHandler.java :100644 100644 ddbf27a... e588ea8... M recipes/jobrunner-yarn/src/main/java/org/apache/helix/provisioning/yarn/example/JobRunnerMain.java Diffs ----- helix-core/src/main/java/org/apache/helix/api/Cluster.java adaf200 helix-core/src/main/java/org/apache/helix/api/Controller.java c94a6e1 helix-core/src/main/java/org/apache/helix/api/Participant.java 3ed395b helix-core/src/main/java/org/apache/helix/api/Resource.java 239748c helix-core/src/main/java/org/apache/helix/api/RunningInstance.java 4e5aedb helix-core/src/main/java/org/apache/helix/api/accessor/ClusterAccessor.java 21d40b1 helix-core/src/main/java/org/apache/helix/api/config/ClusterConfig.java d5dd337 helix-core/src/main/java/org/apache/helix/api/config/ParticipantConfig.java 119ff52 helix-core/src/main/java/org/apache/helix/api/config/ResourceConfig.java 26df5d7 helix-core/src/main/java/org/apache/helix/controller/rebalancer/util/ConstraintBasedAssignment.java addd652 helix-core/src/main/java/org/apache/helix/controller/stages/CompatibilityCheckStage.java 15264ca helix-core/src/main/java/org/apache/helix/controller/stages/ContainerProvisioningStage.java 25645d3 helix-core/src/main/java/org/apache/helix/controller/stages/CurrentStateComputationStage.java 4cc1b9f helix-core/src/main/java/org/apache/helix/controller/stages/ExternalViewComputeStage.java 9f2721f helix-core/src/main/java/org/apache/helix/controller/stages/MessageGenerationStage.java 893e116 helix-core/src/main/java/org/apache/helix/controller/stages/MessageSelectionStage.java b5ed39e helix-core/src/main/java/org/apache/helix/controller/stages/ResourceComputationStage.java 1fc7142 helix-core/src/main/java/org/apache/helix/controller/stages/TaskAssignmentStage.java aa47b4b helix-core/src/main/java/org/apache/helix/model/InstanceConfig.java 2dde23e helix-core/src/main/java/org/apache/helix/model/ResourceConfiguration.java 452ca65 helix-core/src/main/java/org/apache/helix/task/TaskRebalancer.java 29990ed helix-core/src/test/java/org/apache/helix/api/TestNamespacedConfig.java 761ffe2 helix-core/src/test/java/org/apache/helix/api/TestUpdateConfig.java a8d1589 helix-core/src/test/java/org/apache/helix/api/accessor/TestAtomicAccessors.java 9122e62 helix-core/src/test/java/org/apache/helix/controller/stages/BaseStageTest.java 8b26d86 helix-core/src/test/java/org/apache/helix/controller/stages/TestMsgSelectionStage.java 46c0fd9 helix-core/src/test/java/org/apache/helix/controller/strategy/TestNewAutoRebalanceStrategy.java c8ec90a helix-core/src/test/java/org/apache/helix/integration/task/TestTaskRebalancer.java 911832a helix-examples/src/main/java/org/apache/helix/examples/LogicalModelExample.java 163ac5e helix-provisioning/src/main/java/org/apache/helix/provisioning/tools/ContainerAdmin.java fcc137b helix-provisioning/src/main/java/org/apache/helix/provisioning/yarn/NMCallbackHandler.java 7d7883e recipes/jobrunner-yarn/src/main/java/org/apache/helix/provisioning/yarn/example/JobRunnerMain.java ddbf27a Diff: https://reviews.apache.org/r/23956/diff/ Testing ------- Existing tests all pass. Thanks, Kanak Biscuitwala
