----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24067/#review49028 -----------------------------------------------------------
Ship it! Ship It! - Kishore Gopalakrishna On July 29, 2014, 9:27 p.m., Kanak Biscuitwala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24067/ > ----------------------------------------------------------- > > (Updated July 29, 2014, 9:27 p.m.) > > > Review request for helix, Zhen Zhang and Kishore Gopalakrishna. > > > Bugs: HELIX-373 > > > Repository: helix-git > > > Description > ------- > > commit 961b9309059dcaa0ee8dd10eff0adf7f201b05fe > Author: Kanak Biscuitwala <[email protected]> > Date: Tue Jul 29 14:20:18 2014 -0700 > > [HELIX-373] Simplify ClusterAccessor and logical updates > > :100644 100644 ad6811b... 1f0d0f7... M > helix-core/src/main/java/org/apache/helix/api/Participant.java > :100644 100644 83fde95... 3e3bb62... M > helix-core/src/main/java/org/apache/helix/api/accessor/AtomicClusterAccessor.java > :100644 100644 70e600b... 6b92275... M > helix-core/src/main/java/org/apache/helix/api/accessor/ClusterAccessor.java > :100644 100644 f39482c... ed32093... M > helix-core/src/main/java/org/apache/helix/api/config/ClusterConfig.java > :100644 100644 4fd42b9... 0818897... M > helix-core/src/main/java/org/apache/helix/api/config/ParticipantConfig.java > :100644 100644 fd9f20f... b940d11... M > helix-core/src/main/java/org/apache/helix/api/config/ResourceConfig.java > :100644 100644 674140e... d3ee8d1... M > helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixParticipant.java > :100644 100644 a7a7088... 973fe5e... M > helix-core/src/main/java/org/apache/helix/model/ClusterConfiguration.java > :100644 100644 c386035... f3edb62... M > helix-core/src/main/java/org/apache/helix/model/InstanceConfig.java > :100644 100644 001b792... 14cf8a7... M > helix-core/src/main/java/org/apache/helix/model/ResourceConfiguration.java > :100644 100644 a35a47b... b5d218d... M > helix-core/src/test/java/org/apache/helix/api/TestNewStages.java > :100644 000000 feed534... 0000000... D > helix-core/src/test/java/org/apache/helix/api/TestUpdateConfig.java > :100644 100644 c068132... a9bdcbd... M > helix-core/src/test/java/org/apache/helix/api/accessor/TestAccessorRecreate.java > :100644 100644 fd5bc76... 6fd4b40... M > helix-core/src/test/java/org/apache/helix/api/accessor/TestAtomicAccessors.java > :100644 100644 1315574... 3bb17a2... M > helix-core/src/test/java/org/apache/helix/integration/TestHelixConnection.java > :100644 100644 c5b055b... 5ab5f22... M > helix-core/src/test/java/org/apache/helix/integration/TestLocalContainerProvider.java > :100644 100644 9e897a0... e6a8fc4... M > helix-examples/src/main/java/org/apache/helix/examples/LogicalModelExample.java > :100644 100644 5a683b0... 4064e10... M > helix-provisioning/src/main/java/org/apache/helix/provisioning/yarn/AppMasterLauncher.java > > > Diffs > ----- > > helix-core/src/main/java/org/apache/helix/api/Participant.java ad6811b > > helix-core/src/main/java/org/apache/helix/api/accessor/AtomicClusterAccessor.java > 83fde95 > helix-core/src/main/java/org/apache/helix/api/accessor/ClusterAccessor.java > 70e600b > helix-core/src/main/java/org/apache/helix/api/config/ClusterConfig.java > f39482c > helix-core/src/main/java/org/apache/helix/api/config/ParticipantConfig.java > 4fd42b9 > helix-core/src/main/java/org/apache/helix/api/config/ResourceConfig.java > fd9f20f > > helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixParticipant.java > 674140e > helix-core/src/main/java/org/apache/helix/model/ClusterConfiguration.java > a7a7088 > helix-core/src/main/java/org/apache/helix/model/InstanceConfig.java c386035 > helix-core/src/main/java/org/apache/helix/model/ResourceConfiguration.java > 001b792 > helix-core/src/test/java/org/apache/helix/api/TestNewStages.java a35a47b > helix-core/src/test/java/org/apache/helix/api/TestUpdateConfig.java feed534 > > helix-core/src/test/java/org/apache/helix/api/accessor/TestAccessorRecreate.java > c068132 > > helix-core/src/test/java/org/apache/helix/api/accessor/TestAtomicAccessors.java > fd5bc76 > > helix-core/src/test/java/org/apache/helix/integration/TestHelixConnection.java > 1315574 > > helix-core/src/test/java/org/apache/helix/integration/TestLocalContainerProvider.java > c5b055b > > helix-examples/src/main/java/org/apache/helix/examples/LogicalModelExample.java > 9e897a0 > > helix-provisioning/src/main/java/org/apache/helix/provisioning/yarn/AppMasterLauncher.java > 5a683b0 > > Diff: https://reviews.apache.org/r/24067/diff/ > > > Testing > ------- > > Existing tests pass. > > > Thanks, > > Kanak Biscuitwala > >
