----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24121/#review49176 -----------------------------------------------------------
Ship it! helix-core/src/main/java/org/apache/helix/model/builder/IdealStateBuilder.java <https://reviews.apache.org/r/24121/#comment86036> can we always set the nodeGroup probably have a default name? helix-core/src/test/java/org/apache/helix/api/TestNewStages.java <https://reviews.apache.org/r/24121/#comment86037> Need to rename this class and move it to a different package - Kishore Gopalakrishna On July 30, 2014, 9:40 p.m., Kanak Biscuitwala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24121/ > ----------------------------------------------------------- > > (Updated July 30, 2014, 9:40 p.m.) > > > Review request for helix, Zhen Zhang and Kishore Gopalakrishna. > > > Bugs: HELIX-374 > > > Repository: helix-git > > > Description > ------- > > commit 1caffd725814ffe479ade78727ff8ade6bdf54c2 > Author: Kanak Biscuitwala <[email protected]> > Date: Wed Jul 30 14:37:02 2014 -0700 > > [HELIX-374] Rebalancer config should be fully user-specified > > :100644 100644 6b92275... ddf809a... M > helix-core/src/main/java/org/apache/helix/api/accessor/ClusterAccessor.java > :100644 000000 d6aa10e... 0000000... D > helix-core/src/main/java/org/apache/helix/controller/rebalancer/config/BasicRebalancerConfig.java > :100644 000000 a44b230... 0000000... D > helix-core/src/main/java/org/apache/helix/controller/rebalancer/config/CustomRebalancerConfig.java > :100644 000000 16bb4cb... 0000000... D > helix-core/src/main/java/org/apache/helix/controller/rebalancer/config/FullAutoRebalancerConfig.java > :100644 000000 934a9c2... 0000000... D > helix-core/src/main/java/org/apache/helix/controller/rebalancer/config/PartitionedRebalancerConfig.java > :100644 100644 3f8c9d1... b725c9e... M > helix-core/src/main/java/org/apache/helix/controller/rebalancer/config/RebalancerConfig.java > :100644 100644 d6ddb50... 19970c4... M > helix-core/src/main/java/org/apache/helix/controller/rebalancer/config/RebalancerConfigHolder.java > :100644 000000 3118b2a... 0000000... D > helix-core/src/main/java/org/apache/helix/controller/rebalancer/config/ReplicatedRebalancerConfig.java > :100644 000000 60e30f4... 0000000... D > helix-core/src/main/java/org/apache/helix/controller/rebalancer/config/SemiAutoRebalancerConfig.java > :100644 100644 6f34953... f6f5d61... M > helix-core/src/main/java/org/apache/helix/controller/stages/BestPossibleStateCalcStage.java > :100644 100644 deabb56... 810a675... M > helix-core/src/main/java/org/apache/helix/controller/stages/ExternalViewComputeStage.java > :100644 100644 61da673... 4ba249f... M > helix-core/src/main/java/org/apache/helix/controller/stages/MessageGenerationStage.java > :100644 100644 2408e29... 0e4a694... M > helix-core/src/main/java/org/apache/helix/controller/stages/MessageSelectionStage.java > :100644 100644 1036b35... ccd8ae6... M > helix-core/src/main/java/org/apache/helix/controller/stages/ResourceComputationStage.java > :100644 100644 88ec610... b0347ef... M > helix-core/src/main/java/org/apache/helix/model/IdealState.java > :100644 100644 a6707e9... cc4c786... M > helix-core/src/main/java/org/apache/helix/model/builder/IdealStateBuilder.java > :100644 100644 8249b4c... 0d7b0de... M > helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ClusterStatusMonitor.java > :100644 100644 b5d218d... 1809f1b... M > helix-core/src/test/java/org/apache/helix/api/TestNewStages.java > :100644 000000 94deaac... 0000000... D > helix-core/src/test/java/org/apache/helix/controller/rebalancer/context/TestSerializeRebalancerContext.java > :100644 100644 5456884... 0992d2e... M > helix-core/src/test/java/org/apache/helix/controller/stages/BaseStageTest.java > :100644 100644 04a25e9... 130937c... M > helix-core/src/test/java/org/apache/helix/controller/stages/TestResourceComputationStage.java > :100644 100644 b03a48b... 43915c0... M > helix-core/src/test/java/org/apache/helix/integration/TestCustomizedIdealStateRebalancer.java > :100644 100644 3bb17a2... 3d02ae8... M > helix-core/src/test/java/org/apache/helix/integration/TestHelixConnection.java > :100644 100644 5ab5f22... bdde8d3... M > helix-core/src/test/java/org/apache/helix/integration/TestLocalContainerProvider.java > :100644 100644 0ca5dec... 510ec73... M > helix-core/src/test/java/org/apache/helix/integration/TestUserDefRebalancerCompatibility.java > :100644 100644 fe041d0... 36dbe7f... M > helix-core/src/test/java/org/apache/helix/monitoring/mbeans/TestClusterStatusMonitor.java > :100644 100644 e6a8fc4... 6075d22... M > helix-examples/src/main/java/org/apache/helix/examples/LogicalModelExample.java > :100644 100644 acb544a... c49715e... M > helix-provisioning/src/main/java/org/apache/helix/provisioning/tools/UpdateProvisionerConfig.java > :100644 100644 4064e10... 6d96849... M > helix-provisioning/src/main/java/org/apache/helix/provisioning/yarn/AppMasterLauncher.java > > > Diffs > ----- > > helix-core/src/main/java/org/apache/helix/api/accessor/ClusterAccessor.java > 6b92275 > > helix-core/src/main/java/org/apache/helix/controller/rebalancer/config/BasicRebalancerConfig.java > d6aa10e > > helix-core/src/main/java/org/apache/helix/controller/rebalancer/config/CustomRebalancerConfig.java > a44b230 > > helix-core/src/main/java/org/apache/helix/controller/rebalancer/config/FullAutoRebalancerConfig.java > 16bb4cb > > helix-core/src/main/java/org/apache/helix/controller/rebalancer/config/PartitionedRebalancerConfig.java > 934a9c2 > > helix-core/src/main/java/org/apache/helix/controller/rebalancer/config/RebalancerConfig.java > 3f8c9d1 > > helix-core/src/main/java/org/apache/helix/controller/rebalancer/config/RebalancerConfigHolder.java > d6ddb50 > > helix-core/src/main/java/org/apache/helix/controller/rebalancer/config/ReplicatedRebalancerConfig.java > 3118b2a > > helix-core/src/main/java/org/apache/helix/controller/rebalancer/config/SemiAutoRebalancerConfig.java > 60e30f4 > > helix-core/src/main/java/org/apache/helix/controller/stages/BestPossibleStateCalcStage.java > 6f34953 > > helix-core/src/main/java/org/apache/helix/controller/stages/ExternalViewComputeStage.java > deabb56 > > helix-core/src/main/java/org/apache/helix/controller/stages/MessageGenerationStage.java > 61da673 > > helix-core/src/main/java/org/apache/helix/controller/stages/MessageSelectionStage.java > 2408e29 > > helix-core/src/main/java/org/apache/helix/controller/stages/ResourceComputationStage.java > 1036b35 > helix-core/src/main/java/org/apache/helix/model/IdealState.java 88ec610 > > helix-core/src/main/java/org/apache/helix/model/builder/IdealStateBuilder.java > a6707e9 > > helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ClusterStatusMonitor.java > 8249b4c > helix-core/src/test/java/org/apache/helix/api/TestNewStages.java b5d218d > > helix-core/src/test/java/org/apache/helix/controller/rebalancer/context/TestSerializeRebalancerContext.java > 94deaac > > helix-core/src/test/java/org/apache/helix/controller/stages/BaseStageTest.java > 5456884 > > helix-core/src/test/java/org/apache/helix/controller/stages/TestResourceComputationStage.java > 04a25e9 > > helix-core/src/test/java/org/apache/helix/integration/TestCustomizedIdealStateRebalancer.java > b03a48b > > helix-core/src/test/java/org/apache/helix/integration/TestHelixConnection.java > 3bb17a2 > > helix-core/src/test/java/org/apache/helix/integration/TestLocalContainerProvider.java > 5ab5f22 > > helix-core/src/test/java/org/apache/helix/integration/TestUserDefRebalancerCompatibility.java > 0ca5dec > > helix-core/src/test/java/org/apache/helix/monitoring/mbeans/TestClusterStatusMonitor.java > fe041d0 > > helix-examples/src/main/java/org/apache/helix/examples/LogicalModelExample.java > e6a8fc4 > > helix-provisioning/src/main/java/org/apache/helix/provisioning/tools/UpdateProvisionerConfig.java > acb544a > > helix-provisioning/src/main/java/org/apache/helix/provisioning/yarn/AppMasterLauncher.java > 4064e10 > > Diff: https://reviews.apache.org/r/24121/diff/ > > > Testing > ------- > > Existing tests pass. > > > Thanks, > > Kanak Biscuitwala > >
