> On Aug. 7, 2014, 5:28 p.m., Kishore Gopalakrishna wrote:
> > helix-admin-webapp/DISCLAIMER why did we remove these DISCLAIMER files.

They're only for incubator projects.


> On Aug. 7, 2014, 5:28 p.m., Kishore Gopalakrishna wrote:
> > helix-admin-webapp/NOTICE, line 31
> > <https://reviews.apache.org/r/24473/diff/1/?file=655459#file655459line31>
> >
> >     did we remove dependency on zkclient

No, the diff is in the other direction; zkclient was added to the notice


> On Aug. 7, 2014, 5:28 p.m., Kishore Gopalakrishna wrote:
> > recipes/jobrunner-yarn/src/main/resources/job_runner_app_spec.yaml, line 24
> > <https://reviews.apache.org/r/24473/diff/1/?file=655483#file655483line24>
> >
> >     location points your workspace kbiscuit? u can fix this with a separate 
> > jira

The other recipe points to kgopalak... we need to make this pluggable somehow.


- Kanak


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24473/#review49983
-----------------------------------------------------------


On Aug. 7, 2014, 2:50 p.m., Kanak Biscuitwala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24473/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2014, 2:50 p.m.)
> 
> 
> Review request for helix, Zhen Zhang and Kishore Gopalakrishna.
> 
> 
> Bugs: HELIX-498
> 
> 
> Repository: helix-git
> 
> 
> Description
> -------
> 
> commit ecfedff24185001363e0795a4ca461e65bd5ac03
> Author: Kanak Biscuitwala <[email protected]>
> Date:   Thu Aug 7 14:48:21 2014 -0700
> 
>     [HELIX-498] Update configurations and static files to reflect TLP
> 
> :100644 000000 2001d31... 0000000... D        DISCLAIMER
> :100644 000000 a3af24b... 0000000... D        HelixProposal.mediawiki
> :000000 100644 0000000... ca4a5e0... A        NOTICE
> :100644 000000 2001d31... 0000000... D        helix-admin-webapp/DISCLAIMER
> :100644 100644 e070e15... ca4a5e0... M        helix-admin-webapp/NOTICE
> :000000 100644 0000000... b0673af... A        
> helix-admin-webapp/helix-admin-webapp-0.7.1-SNAPSHOT.ivy
> :100644 000000 35c6158... 0000000... D        
> helix-admin-webapp/helix-admin-webapp-0.7.1-incubating-SNAPSHOT.ivy
> :100644 100644 b4f38b5... 9f16e98... M        helix-admin-webapp/pom.xml
> :100644 000000 2001d31... 0000000... D        helix-agent/DISCLAIMER
> :100644 100644 e070e15... 1ee0d24... M        helix-agent/NOTICE
> :100644 100644 7d2a0ce... c2b697a... M        helix-agent/pom.xml
> :100644 000000 2001d31... 0000000... D        helix-core/DISCLAIMER
> :100644 100644 e070e15... 1ee0d24... M        helix-core/NOTICE
> :000000 100644 0000000... de104a4... A        
> helix-core/helix-core-0.7.1-SNAPSHOT.ivy
> :100644 000000 eb37bed... 0000000... D        
> helix-core/helix-core-0.7.1-incubating-SNAPSHOT.ivy
> :100644 100644 8bb9ed1... 7c4e6eb... M        helix-core/pom.xml
> :100644 000000 2001d31... 0000000... D        helix-examples/DISCLAIMER
> :100644 100644 e070e15... 1ee0d24... M        helix-examples/NOTICE
> :100644 100644 c3b319c... 7fa3053... M        helix-examples/pom.xml
> :100644 000000 2001d31... 0000000... D        helix-provisioning/DISCLAIMER
> :100644 100644 e070e15... 1ee0d24... M        helix-provisioning/NOTICE
> :100644 100644 0c02919... f3fa05a... M        helix-provisioning/pom.xml
> :100644 100644 dc5cc88... da5d476... M        pom.xml
> :100644 100644 f3b2fbe... 4a8b99d... M        
> recipes/distributed-lock-manager/README.md
> :100644 100644 f9f6385... 9e563b8... M        
> recipes/distributed-lock-manager/pom.xml
> :100644 100644 fe41e9c... 2e165bd... M        
> recipes/helloworld-provisioning-yarn/pom.xml
> :100755 100755 761c97e... f8679de... M        
> recipes/helloworld-provisioning-yarn/src/main/resources/hello_world_app_spec.yaml
> :100644 100644 c4d560f... 8f8c12f... M        recipes/jobrunner-yarn/pom.xml
> :100755 100755 83c7edf... 6793ebe... M        
> recipes/jobrunner-yarn/src/main/resources/job_runner_app_spec.yaml
> :100644 100644 3fcaf42... 577acb3... M        recipes/pom.xml
> :100644 100644 0eac7f4... dbb7c21... M        
> recipes/rabbitmq-consumer-group/README.md
> :100644 100644 9b749bb... ae9032a... M        
> recipes/rabbitmq-consumer-group/pom.xml
> :100644 100644 f8a74a0... fc488f7... M        
> recipes/rsync-replicated-file-system/README.md
> :100644 100644 7d27f1f... 9e1864b... M        
> recipes/rsync-replicated-file-system/pom.xml
> :100644 100644 8e06ead... e7a52bd... M        
> recipes/service-discovery/README.md
> :100644 100644 a876614... dd472de... M        
> recipes/service-discovery/pom.xml
> :100644 100644 f0474e4... 14e6153... M        recipes/task-execution/README.md
> :100644 100644 27464c9... a5130de... M        recipes/task-execution/pom.xml
> :100644 100644 3dca51c... 82ca593... M        
> recipes/user-defined-rebalancer/README.md
> :100644 100644 8eba035... 56c1765... M        
> recipes/user-defined-rebalancer/pom.xml
> :100644 100644 96529d1... c77f704... M        website/0.6.1-incubating/pom.xml
> :100644 100644 785147b... 840c8c2... M        website/0.6.2-incubating/pom.xml
> :100644 100644 2499562... 1a95ebc... M        website/0.6.3/pom.xml
> :100644 100644 ae6a9f5... 2cd0753... M        website/0.7.0-incubating/pom.xml
> :100644 100644 e74a377... 9b28d8f... M        website/pom.xml
> :100644 100644 cdd2951... 2fb4f88... M        website/trunk/pom.xml
> 
> 
> Diffs
> -----
> 
>   DISCLAIMER 2001d31 
>   HelixProposal.mediawiki a3af24b 
>   NOTICE PRE-CREATION 
>   helix-admin-webapp/DISCLAIMER 2001d31 
>   helix-admin-webapp/NOTICE e070e15 
>   helix-admin-webapp/helix-admin-webapp-0.7.1-SNAPSHOT.ivy PRE-CREATION 
>   helix-admin-webapp/helix-admin-webapp-0.7.1-incubating-SNAPSHOT.ivy 35c6158 
>   helix-admin-webapp/pom.xml b4f38b5 
>   helix-agent/DISCLAIMER 2001d31 
>   helix-agent/NOTICE e070e15 
>   helix-agent/pom.xml 7d2a0ce 
>   helix-core/DISCLAIMER 2001d31 
>   helix-core/NOTICE e070e15 
>   helix-core/helix-core-0.7.1-SNAPSHOT.ivy PRE-CREATION 
>   helix-core/helix-core-0.7.1-incubating-SNAPSHOT.ivy eb37bed 
>   helix-core/pom.xml 8bb9ed1 
>   helix-examples/DISCLAIMER 2001d31 
>   helix-examples/NOTICE e070e15 
>   helix-examples/pom.xml c3b319c 
>   helix-provisioning/DISCLAIMER 2001d31 
>   helix-provisioning/NOTICE e070e15 
>   helix-provisioning/pom.xml 0c02919 
>   pom.xml dc5cc88 
>   recipes/distributed-lock-manager/README.md f3b2fbe 
>   recipes/distributed-lock-manager/pom.xml f9f6385 
>   recipes/helloworld-provisioning-yarn/pom.xml fe41e9c 
>   
> recipes/helloworld-provisioning-yarn/src/main/resources/hello_world_app_spec.yaml
>  761c97e 
>   recipes/jobrunner-yarn/pom.xml c4d560f 
>   recipes/jobrunner-yarn/src/main/resources/job_runner_app_spec.yaml 83c7edf 
>   recipes/pom.xml 3fcaf42 
>   recipes/rabbitmq-consumer-group/README.md 0eac7f4 
>   recipes/rabbitmq-consumer-group/pom.xml 9b749bb 
>   recipes/rsync-replicated-file-system/README.md f8a74a0 
>   recipes/rsync-replicated-file-system/pom.xml 7d27f1f 
>   recipes/service-discovery/README.md 8e06ead 
>   recipes/service-discovery/pom.xml a876614 
>   recipes/task-execution/README.md f0474e4 
>   recipes/task-execution/pom.xml 27464c9 
>   recipes/user-defined-rebalancer/README.md 3dca51c 
>   recipes/user-defined-rebalancer/pom.xml 8eba035 
>   website/0.6.1-incubating/pom.xml 96529d1 
>   website/0.6.2-incubating/pom.xml 785147b 
>   website/0.6.3/pom.xml 2499562 
>   website/0.7.0-incubating/pom.xml ae6a9f5 
>   website/pom.xml e74a377 
>   website/trunk/pom.xml cdd2951 
> 
> Diff: https://reviews.apache.org/r/24473/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kanak Biscuitwala
> 
>

Reply via email to