----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24335/#review50006 -----------------------------------------------------------
Ship it! - Kishore Gopalakrishna On Aug. 5, 2014, 8:15 p.m., Kanak Biscuitwala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24335/ > ----------------------------------------------------------- > > (Updated Aug. 5, 2014, 8:15 p.m.) > > > Review request for helix, Zhen Zhang and Kishore Gopalakrishna. > > > Bugs: HELIX-422 > > > Repository: helix-git > > > Description > ------- > > commit 5bc77ac195e91292ceb2fb3584dce7a98175a623 > Author: Kanak Biscuitwala <[email protected]> > Date: Tue Aug 5 13:10:52 2014 -0700 > > [HELIX-422] Simplify single job creation > > This both augments the Java API to specify fully-built job configs, as > well as reduce the confusion between the job configs and the command > config maps they contain. > > :100644 100644 3f9ab41... 1dad5e4... M > helix-core/src/main/java/org/apache/helix/task/JobConfig.java > :100644 100644 1aa75d6... e1a96a8... M > helix-core/src/main/java/org/apache/helix/task/TaskUtil.java > :100644 100644 84680d3... 77a5ba7... M > helix-core/src/main/java/org/apache/helix/task/Workflow.java > :100644 100644 b5856b1... b7f20d1... M > helix-core/src/test/java/org/apache/helix/integration/task/TestIndependentTaskRebalancer.java > :100644 100644 208480c... 2ce76c1... M > helix-core/src/test/java/org/apache/helix/integration/task/TestTaskRebalancer.java > :100644 100644 97b8c7e... 4e0d92a... M > helix-core/src/test/java/org/apache/helix/integration/task/TestTaskRebalancerStopResume.java > :100644 100644 921a5f9... 318673f... M > helix-core/src/test/java/org/apache/helix/integration/task/WorkflowGenerator.java > > > Diffs > ----- > > helix-core/src/main/java/org/apache/helix/task/JobConfig.java 3f9ab41 > helix-core/src/main/java/org/apache/helix/task/TaskUtil.java 1aa75d6 > helix-core/src/main/java/org/apache/helix/task/Workflow.java 84680d3 > > helix-core/src/test/java/org/apache/helix/integration/task/TestIndependentTaskRebalancer.java > b5856b1 > > helix-core/src/test/java/org/apache/helix/integration/task/TestTaskRebalancer.java > 208480c > > helix-core/src/test/java/org/apache/helix/integration/task/TestTaskRebalancerStopResume.java > 97b8c7e > > helix-core/src/test/java/org/apache/helix/integration/task/WorkflowGenerator.java > 921a5f9 > > Diff: https://reviews.apache.org/r/24335/diff/ > > > Testing > ------- > > > Thanks, > > Kanak Biscuitwala > >
