----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24716/#review50645 -----------------------------------------------------------
Ship it! Ship It! - Kanak Biscuitwala On Aug. 14, 2014, 2:14 p.m., Zhen Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24716/ > ----------------------------------------------------------- > > (Updated Aug. 14, 2014, 2:14 p.m.) > > > Review request for helix, Kanak Biscuitwala and Kishore Gopalakrishna. > > > Bugs: 485 > > > Repository: helix-git > > > Description > ------- > > [HELIX-485] Remove controller leader election duplicate code > > > Diffs > ----- > > > helix-core/src/main/java/org/apache/helix/manager/zk/DistributedLeaderElection.java > fe1ca4b > helix-core/src/main/java/org/apache/helix/manager/zk/ZkCallbackHandler.java > 374a30b > helix-core/src/test/java/org/apache/helix/manager/zk/MockController.java > f4d2159 > > helix-core/src/test/java/org/apache/helix/manager/zk/MockMultiClusterController.java > a39bd84 > helix-core/src/test/java/org/apache/helix/manager/zk/MockParticipant.java > 3936680 > > helix-core/src/test/java/org/apache/helix/participant/MockZKHelixManager.java > 3efbffb > > helix-core/src/test/java/org/apache/helix/participant/TestControllerElection.java > PRE-CREATION > > helix-core/src/test/java/org/apache/helix/participant/TestDistControllerElection.java > de510c1 > > Diff: https://reviews.apache.org/r/24716/diff/ > > > Testing > ------- > > mvn test > > > Thanks, > > Zhen Zhang > >
