----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24807/#review50914 -----------------------------------------------------------
Ship it! helix-core/src/main/java/org/apache/helix/participant/MultiClusterControllerStateModel.java <https://reviews.apache.org/r/24807/#comment88793> Rename to MultiClusterControllerTransitionHandler helix-core/src/main/java/org/apache/helix/participant/MultiClusterControllerStateModelFactory.java <https://reviews.apache.org/r/24807/#comment88795> Rename to MultiClusterControllerTransitionHandlerFactory - Kanak Biscuitwala On Aug. 18, 2014, 11:07 a.m., Zhen Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24807/ > ----------------------------------------------------------- > > (Updated Aug. 18, 2014, 11:07 a.m.) > > > Review request for helix, Kanak Biscuitwala and Kishore Gopalakrishna. > > > Bugs: HELIX-329 > > > Repository: helix-git > > > Description > ------- > > [HELIX-329] HelixAutoController isn't a very clear name, consider renaming > > > Diffs > ----- > > > helix-admin-webapp/src/test/java/org/apache/helix/webapp/TestHelixAdminScenariosRest.java > 5aa26d2 > helix-core/src/main/java/org/apache/helix/HelixConnection.java 4b7487b > helix-core/src/main/java/org/apache/helix/HelixManager.java 9e2bd14 > > helix-core/src/main/java/org/apache/helix/controller/HelixControllerMain.java > ca540c5 > helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixManager.java > 12a3fe6 > helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixConnection.java > 0a9dc94 > > helix-core/src/main/java/org/apache/helix/participant/DistClusterControllerStateModel.java > 4579810 > > helix-core/src/main/java/org/apache/helix/participant/DistClusterControllerStateModelFactory.java > 5f21e90 > > helix-core/src/main/java/org/apache/helix/participant/MultiClusterControllerStateModel.java > PRE-CREATION > > helix-core/src/main/java/org/apache/helix/participant/MultiClusterControllerStateModelFactory.java > PRE-CREATION > helix-core/src/test/java/org/apache/helix/integration/TestAddClusterV2.java > 5d7df59 > > helix-core/src/test/java/org/apache/helix/integration/TestAddNodeAfterControllerStart.java > 97acc1c > > helix-core/src/test/java/org/apache/helix/integration/TestDistributedCMMain.java > cf32d73 > > helix-core/src/test/java/org/apache/helix/integration/TestMultiClusterController.java > 8945843 > > helix-core/src/test/java/org/apache/helix/integration/TestReelectedPipelineCorrectness.java > e522008 > > helix-core/src/test/java/org/apache/helix/integration/manager/TestConsecutiveZkSessionExpiry.java > 1b55af5 > > helix-core/src/test/java/org/apache/helix/integration/manager/TestHelixMultiClusterController.java > 51e7e19 > > helix-core/src/test/java/org/apache/helix/manager/zk/MockMultiClusterController.java > f68444c > > helix-core/src/test/java/org/apache/helix/manager/zk/TestZkHelixAutoController.java > a34dc66 > > helix-core/src/test/java/org/apache/helix/manager/zk/TestZkHelixMultiClusterController.java > PRE-CREATION > > helix-core/src/test/java/org/apache/helix/monitoring/TestClusterStatusMonitorLifecycle.java > 2b8d5e5 > > helix-core/src/test/java/org/apache/helix/participant/TestDistControllerStateModel.java > 116cd72 > > helix-core/src/test/java/org/apache/helix/participant/TestDistControllerStateModelFactory.java > 7055500 > > helix-core/src/test/java/org/apache/helix/participant/TestMultiClusterControllerStateModel.java > PRE-CREATION > > helix-core/src/test/java/org/apache/helix/participant/TestMultiClusterControllerStateModelFactory.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/24807/diff/ > > > Testing > ------- > > mvn test > > > Thanks, > > Zhen Zhang > >
