----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25453/#review52636 -----------------------------------------------------------
Ship it! Ship It! - Shi Lu On Sept. 8, 2014, 9:08 p.m., Zhen Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25453/ > ----------------------------------------------------------- > > (Updated Sept. 8, 2014, 9:08 p.m.) > > > Review request for helix and Shi Lu. > > > Bugs: HELIX-514 > > > Repository: helix-git > > > Description > ------- > > ZkBaseDataAccessor#set() should throw BadVersionException instead of return > false in case of version mismatch, since caller (e.g. > HelixGroupCommit#commit()) may need to distinguish between fatal error and > transient error (e.g. version mismatch) so it can retry. > > > Diffs > ----- > > helix-core/src/main/java/org/apache/helix/manager/zk/HelixGroupCommit.java > 8dd9d77 > > helix-core/src/main/java/org/apache/helix/manager/zk/ZkBaseDataAccessor.java > 231ce77 > > Diff: https://reviews.apache.org/r/25453/diff/ > > > Testing > ------- > > mvn test > > > Thanks, > > Zhen Zhang > >
