The steps are straightforward, and I can document them on the wiki: 0. Do a code review on the pull request on GitHub until it meets standards (e.g. code style, correctness, etc)
1. Check out helix from apache. 2. Pull changes from remote fork, e.g. git pull https://github.com/brandtg/helix master 2a. If git creates a merge commit message, append "(This closes #[PRNUM])" to the end, otherwise, create a new empty commit with at least that text 3. Run tests and rat: mvn test mvn -Prat -DskipTests 4. git push origin master ---------------------------------------- > Date: Tue, 16 Sep 2014 11:41:38 -0700 > Subject: Re: [GitHub] helix pull request: refactored Netty IPC code into > separate classe... > From: [email protected] > To: [email protected] > > Do we have any documented on how to merge this pull request. Will be nice > to have a script that does some validation? > > thanks, > Kishore G > > On Tue, Sep 16, 2014 at 9:49 AM, brandtg <[email protected]> wrote: > >> GitHub user brandtg opened a pull request: >> >> https://github.com/apache/helix/pull/5 >> >> refactored Netty IPC code into separate classes >> >> >> >> You can merge this pull request into a Git repository by running: >> >> $ git pull https://github.com/brandtg/helix master >> >> Alternatively you can review and apply these changes as the patch at: >> >> https://github.com/apache/helix/pull/5.patch >> >> To close this pull request, make a commit to your master/trunk branch >> with (at least) the following in the commit message: >> >> This closes #5 >> >> ---- >> commit 21ecdc7c5ef7f4e2ad7a98239b5d70164ee83505 >> Author: Greg Brandt <[email protected]> >> Date: 2014-09-16T16:48:14Z >> >> refactored Netty IPC code into separte classes >> >> ---- >> >> >> --- >> If your project is set up for it, you can reply to this email and have your >> reply appear on GitHub as well. If your project does not have this feature >> enabled and wishes so, or if the feature is enabled but not working, please >> contact infrastructure at [email protected] or file a JIRA ticket >> with INFRA. >> --- >>
